From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dkim1.fusionio.com ([66.114.96.53]:60237 "EHLO dkim1.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754752Ab3IYOL1 (ORCPT ); Wed, 25 Sep 2013 10:11:27 -0400 Received: from mx1.fusionio.com (unknown [10.101.1.160]) by dkim1.fusionio.com (Postfix) with ESMTP id 4BC5C7C04D8 for ; Wed, 25 Sep 2013 08:11:27 -0600 (MDT) Date: Wed, 25 Sep 2013 10:11:25 -0400 From: Josef Bacik To: Miao Xie CC: Subject: Re: [PATCH 2/3] Btrfs: fix oops caused by the space balance and dead roots Message-ID: <20130925141125.GE18681@localhost.localdomain> References: <1380116865-23406-1-git-send-email-miaox@cn.fujitsu.com> <1380116865-23406-2-git-send-email-miaox@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <1380116865-23406-2-git-send-email-miaox@cn.fujitsu.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, Sep 25, 2013 at 09:47:44PM +0800, Miao Xie wrote: > When doing space balance and subvolume destroy at the same time, we met > the following oops: > > kernel BUG at fs/btrfs/relocation.c:2247! > RIP: 0010: [] prepare_to_merge+0x154/0x1f0 [btrfs] > Call Trace: > [] relocate_block_group+0x466/0x4e6 [btrfs] > [] btrfs_relocate_block_group+0x143/0x275 [btrfs] > [] btrfs_relocate_chunk.isra.27+0x5c/0x5a2 [btrfs] > [] ? btrfs_item_key_to_cpu+0x15/0x31 [btrfs] > [] ? btrfs_get_token_64+0x7e/0xcd [btrfs] > [] ? btrfs_tree_read_unlock_blocking+0xb2/0xb7 [btrfs] > [] btrfs_balance+0x9c7/0xb6f [btrfs] > [] btrfs_ioctl_balance+0x234/0x2ac [btrfs] > [] btrfs_ioctl+0xd87/0x1ef9 [btrfs] > [] ? path_openat+0x234/0x4db > [] ? __do_page_fault+0x31d/0x391 > [] ? vma_link+0x74/0x94 > [] vfs_ioctl+0x1d/0x39 > [] do_vfs_ioctl+0x32d/0x3e2 > [] SyS_ioctl+0x57/0x83 > [] ? do_page_fault+0xe/0x10 > [] system_call_fastpath+0x16/0x1b > Can you put this into an xfstest please so I can reproduce and verify your patch fixes the problem? Thanks, Josef