From: David Sterba <dsterba@suse.cz>
To: Frank Holton <fholton@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] btrfs-progs: Add recursive defrag using -r option
Date: Tue, 1 Oct 2013 14:59:40 +0200 [thread overview]
Message-ID: <20131001125939.GC18291@twin.jikos.cz> (raw)
In-Reply-To: <20ddb7ded6d0bedadd7dc68a2c29d7c3bd4b7906.1379963692.git.fholton@gmail.com>
On Mon, Sep 23, 2013 at 03:18:17PM -0400, Frank Holton wrote:
> Add an option to defrag all files in a directory recursively.
I had this patch merged but still saw some problems. If there's eg. a
symlink to file on another filesystem, defrag fails with
"ERROR: defrag range ioctl not supported in this kernel, please try
without any options."
which does not match the error that occured.
In short, we have to use nftw and specify FTW_MOUNT (do not dive into
mountpoints) and FTW_PHYS (do not follow symlinks). Fixed and added to
integration. Please write the corresponding bits of manpage and send a
patch.
thanks,
david
prev parent reply other threads:[~2013-10-01 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 19:18 [PATCH v3] btrfs-progs: Add recursive defrag using -r option Frank Holton
2013-10-01 12:59 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001125939.GC18291@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fholton@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).