From: Johannes Hirte <johannes.hirte@datenkhaos.de>
To: Josef Bacik <jbacik@fusionio.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: relocate csums properly with prealloc extents
Date: Fri, 4 Oct 2013 23:19:48 +0200 [thread overview]
Message-ID: <20131004231948.0ee4e03c@datenkhaos.de> (raw)
In-Reply-To: <1380289020-2515-1-git-send-email-jbacik@fusionio.com>
On Fri, 27 Sep 2013 09:37:00 -0400
Josef Bacik <jbacik@fusionio.com> wrote:
> A user reported a problem where they were getting csum errors when
> running a balance and running systemd's journal. This is because
> systemd is awesome and fallocate()'s its log space and writes into
> it. Unfortunately we assume that when we read in all the csums for
> an extent that they are sequential starting at the bytenr we care
> about. This obviously isn't the case for prealloc extents, where we
> could have written to the middle of the prealloc extent only, which
> means the csum would be for the bytenr in the middle of our range and
> not the front of our range. Fix this by offsetting the new bytenr we
> are logging to based on the original bytenr the csum was for. With
> this patch I no longer see the csum errors I was seeing. Thanks,
Any assessment when this goes upstream? Until it hit Linus tree it
won't won't appear in stable. And this seems rather important.
next prev parent reply other threads:[~2013-10-04 21:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 13:37 [PATCH] Btrfs: relocate csums properly with prealloc extents Josef Bacik
2013-10-04 21:19 ` Johannes Hirte [this message]
2013-10-23 21:24 ` Hans-Kristian Bakke
2013-10-23 21:49 ` Hans-Kristian Bakke
2013-10-24 16:19 ` Hans-Kristian Bakke
2013-10-24 14:08 ` [PATCH] Btrfs: relocate csums properly with prealloc extents - for 3.12-rc David Sterba
2013-11-25 16:51 ` [PATCH] Btrfs: relocate csums properly with prealloc extents David Sterba
2013-11-25 21:01 ` Greg KH
2013-11-30 7:39 ` Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004231948.0ee4e03c@datenkhaos.de \
--to=johannes.hirte@datenkhaos.de \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).