From: David Sterba <dsterba@suse.cz>
To: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH v3 02/12] Btrfs-progs: introduces '-p' option to print the ID of the parent qgroups
Date: Tue, 8 Oct 2013 17:06:37 +0200 [thread overview]
Message-ID: <20131008150637.GC4322@twin.jikos.cz> (raw)
In-Reply-To: <1381130508-8458-3-git-send-email-wangsl.fnst@cn.fujitsu.com>
On Mon, Oct 07, 2013 at 03:21:38PM +0800, Wang Shilong wrote:
> +static void print_parent_column(struct btrfs_qgroup *qgroup)
> +{
> + struct btrfs_qgroup_list *list = NULL;
> +
> + list_for_each_entry(list, &qgroup->qgroups, next_qgroup) {
> + printf("%llu/%llu", (list->qgroup)->qgroupid >> 48,
> + ((1ll << 48) - 1) & (list->qgroup)->qgroupid);
Please use a wrapper for the >> 48 calculations everywhere (another
patch).
thanks,
david
next prev parent reply other threads:[~2013-10-08 15:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 7:21 [PATCH v3 00/12] enhance btrfs qgroup show command Wang Shilong
2013-10-07 7:21 ` [PATCH v3 01/12] Btrfs-progs: restructure show_qgroups Wang Shilong
2013-10-07 7:21 ` [PATCH v3 02/12] Btrfs-progs: introduces '-p' option to print the ID of the parent qgroups Wang Shilong
2013-10-08 15:06 ` David Sterba [this message]
2013-10-07 7:21 ` [PATCH v3 03/12] Btrfs-progs: introduces '-c' option to print the ID of the child qgroups Wang Shilong
2013-10-08 15:08 ` David Sterba
2013-10-07 7:21 ` [PATCH v3 04/12] Btrfs-progs: introduce '-r' option to print max referenced size of qgroups Wang Shilong
2013-10-07 7:21 ` [PATCH v3 05/12] Btrfs-progs: introduce '-e' option to print max exclusive " Wang Shilong
2013-10-07 7:21 ` [PATCH v3 06/12] Btrfs-progs: list all qgroups impact given path(include ancestral qgroups) Wang Shilong
2013-10-07 7:21 ` [PATCH v3 07/12] Btrfs-progs: list all qgroups impact given path(exclude " Wang Shilong
2013-10-07 7:21 ` [PATCH v3 08/12] Btrfs-progs: enhance btrfs qgroup show to sort qgroups Wang Shilong
2013-10-07 7:21 ` [PATCH v3 09/12] Btrfs-progs: enhance btrfs qgroup to print the result as a table Wang Shilong
2013-10-07 7:21 ` [PATCH v3 10/12] Btrfs-progs: add '--block-size' option to control print result Wang Shilong
2013-10-08 15:34 ` David Sterba
2013-10-08 16:27 ` Shilong Wang
2013-10-08 16:34 ` Shilong Wang
2013-10-08 16:34 ` David Sterba
2013-10-08 16:54 ` Shilong Wang
2013-10-08 17:01 ` Hugo Mills
2013-10-08 17:10 ` Hugo Mills
2013-10-07 7:21 ` [PATCH v3 11/12] Btrfs-progs: make pretty_size_snprintf() return len Wang Shilong
2013-10-07 7:21 ` [PATCH v3 12/12] Btrfs-progs: add '-h' options to print sizes in human readable format Wang Shilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008150637.GC4322@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangsl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).