From: Liu Bo <bo.li.liu@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: do not defrag extent root in ioctl
Date: Wed, 9 Oct 2013 10:45:03 +0800 [thread overview]
Message-ID: <20131009024502.GA11033@localhost.localdomain> (raw)
In-Reply-To: <20131008141623.GB4322@twin.jikos.cz>
On Tue, Oct 08, 2013 at 04:16:23PM +0200, David Sterba wrote:
> On Tue, Oct 08, 2013 at 06:19:30PM +0800, Liu Bo wrote:
> > We can't defrag the extent root without deadlock.
>
> Deadlock under what circumstance? Eg. with snapshot aware defag turned
> on or extent tree cannot be safely defragmented at all?
Hmm, my assumption is based on the comments in btrfs_defrag_leaves(),
Quoting,
"there's recursion here right now in the tree locking, we can't defrag the
extent root without deadlock."
But I just made a quick test, defragment on extent root seems to be good.
I need to dig this more, thanks for pointing out that, Dave.
-liubo
prev parent reply other threads:[~2013-10-09 2:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 10:19 [PATCH] Btrfs: do not defrag extent root in ioctl Liu Bo
2013-10-08 14:16 ` David Sterba
2013-10-09 2:45 ` Liu Bo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009024502.GA11033@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).