From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3 v4] btrfs-progs: use kernel for mounted disk for show
Date: Wed, 16 Oct 2013 15:09:27 +0200 [thread overview]
Message-ID: <20131016130927.GT5787@suse.cz> (raw)
In-Reply-To: <525E5B91.4050808@oracle.com>
On Wed, Oct 16, 2013 at 05:25:37PM +0800, Anand Jain wrote:
> Ah. good catch. but what do you suggest. ?
> as of now user on disk-group is able to do things like,
> check --repair. but won't be able to list the subvol /
> manage the snapshots, and is able to run btrfs fi show -d
> but won't be able to run btrfs fi show / -m. what do we
> do in this case ?
We can drop the CAP_SYS_ADMIN check from btrfs_ioctl_fs_info, it does
not do or revealy sensitive information.
> OR when /sys interface is ready that should help to manage
> based on the user-groups.?
This could be decided case by case if a sysfs file should not be
publicly readable, otherwise let them be readable to everyone.
david
next prev parent reply other threads:[~2013-10-16 13:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 3:41 [PATCH 1/3 v4] btrfs-progs: use kernel for mounted disk for show Anand Jain
2013-10-08 3:41 ` [PATCH 2/3 v2] btrfs-progs: add more parameter to the filesystem show Anand Jain
2013-10-15 17:22 ` David Sterba
2013-10-16 2:22 ` Anand Jain
2013-10-08 3:41 ` [PATCH 3/3] btrfs-progs: use BTRFS_SCAN_LBLKID as default scan in " Anand Jain
2013-10-15 17:13 ` [PATCH 1/3 v4] btrfs-progs: use kernel for mounted disk for show David Sterba
2013-10-16 9:25 ` Anand Jain
2013-10-16 13:09 ` David Sterba [this message]
2013-10-21 14:44 ` Josef Bacik
2013-10-22 5:53 ` Anand Jain
2013-10-22 13:21 ` Josef Bacik
2013-10-22 13:28 ` Hugo Mills
2013-10-22 16:52 ` David Sterba
2013-10-23 11:20 ` Anand Jain
2013-10-23 11:41 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016130927.GT5787@suse.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).