Question

Question

[Morey Roof]

I was wondering if someone could give me a few hints.  I noticed that
all patches have [PATCH] in the subject.  Should this always be done?
Also, any other general rules to follow that could be passed on would
be nice.

Thanks,

Morey

Re: Question

[Jeff Schroeder]

On Tue, Aug 12, 2008 at 1:06 PM, Morey Roof <moreyroof@gmail.com> wrote:
> I was wondering if someone could give me a few hints.  I noticed that
> all patches have [PATCH] in the subject.  Should this always be done?
> Also, any other general rules to follow that could be passed on would
> be nice.

Chris feel free to correct me on this, but...
Since btrfs is Linux kernel code, the same rules apply for btrfs kernel code as
they do for Linux kernel code. Take a look at Documentation/SubmittingPatches
in a checkout of the kernel source. It is online here:
http://users.sosdg.org/~qiyong/lxr/source/Documentation/SubmittingPatches

You can format your patch submission emails correctly with git-send-email(1).

> Morey

-- 
Jeff Schroeder

Don't drink and derive, alcohol and analysis don't mix.
http://www.digitalprognosis.com

Re: Question

[Chris Mason]

On Tue, 2008-08-12 at 13:32 -0700, Jeff Schroeder wrote:
> On Tue, Aug 12, 2008 at 1:06 PM, Morey Roof <moreyroof@gmail.com> wrote:
> > I was wondering if someone could give me a few hints.  I noticed that
> > all patches have [PATCH] in the subject.  Should this always be done?
> > Also, any other general rules to follow that could be passed on would
> > be nice.
> 
> Chris feel free to correct me on this, but...
> Since btrfs is Linux kernel code, the same rules apply for btrfs kernel code as
> they do for Linux kernel code. Take a look at Documentation/SubmittingPatches
> in a checkout of the kernel source. It is online here:
> http://users.sosdg.org/~qiyong/lxr/source/Documentation/SubmittingPatches
> 
> You can format your patch submission emails correctly with git-send-email(1).

Yes, in general the same rules apply to btrfs as the rest of the kernel.
But, one of my goals it to get new people involved and so I try fixup
imperfect patches as well.

-chris

question

[lilofile]

when i read transaction_kthread function in disk-io.c 

delay = HZ * 30;

why commit transaction is 30 seconds,  Other values 20 seconds,10 seconds?
what considerations about the commit transaction interval?

Re: question

[Hugo Mills]

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

On Sun, Oct 20, 2013 at 11:19:26PM +0800, lilofile wrote:
> 
> when i read transaction_kthread function in disk-io.c 
> 
> delay = HZ * 30;
> 
> why commit transaction is 30 seconds,  Other values 20 seconds,10 seconds?
> what considerations about the commit transaction interval?

   It's a more or less arbitrary number. There's been a patch recently
(last couple of months) to allow modifying the value. If you make it
too large, you end up using lots of RAM for unflushed changes, you
risk losing those changes if the machine crashes. If you make it too
small, you end up writing lots more metadata, because that's always
changing as the FS is modified.

   Hugo.

-- 
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 65E74AC0 from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
  --- There are three things you should never see being made: laws, ---  
                        standards,  and sausages.                        

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 828 bytes --]