From: Hugo Mills <hugo@carfax.org.uk>
To: Josef Bacik <jbacik@fusionio.com>
Cc: Anand Jain <Anand.Jain@oracle.com>,
dsterba@suse.cz, linux-btrfs@vger.kernel.org,
chris.mason@fusionio.com
Subject: Re: [PATCH 1/3 v4] btrfs-progs: use kernel for mounted disk for show
Date: Tue, 22 Oct 2013 14:28:31 +0100 [thread overview]
Message-ID: <20131022132831.GH6598@carfax.org.uk> (raw)
In-Reply-To: <20131022132147.GA27304@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]
On Tue, Oct 22, 2013 at 09:21:47AM -0400, Josef Bacik wrote:
> On Tue, Oct 22, 2013 at 01:53:47PM +0800, Anand Jain wrote:
> > That would be less productive approach as a whole.
> > I have sent out the fix for this. Kindly find it.
> >
> > ---
> > [PATCH 1/2] btrfs-progs: make get_btrfs_mount callable
> > [PATCH 2/2] btrfs-progs: filesystem show of specified mounted disk should
> > work
> > ---
> >
>
> Did you test these? Because they aren't working for me, so I think a revert is
> the only solution. Thanks,
Just for the avoidance of doubt -- Josef means a full xfstests run
on the patches. It may take a long time, but it does mean that
everything(*) gets tested for regressions and helps prevent this
to-and-fro of patches trying to fix up earlier bugs.
Hugo.
(*) OK, not quite everything, but Eric's and Josef's recent work is
taking us closer to that goal.
--
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
PGP key: 65E74AC0 from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
--- "What's so bad about being drunk?" "You ask a glass of water" ---
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2013-10-22 13:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 3:41 [PATCH 1/3 v4] btrfs-progs: use kernel for mounted disk for show Anand Jain
2013-10-08 3:41 ` [PATCH 2/3 v2] btrfs-progs: add more parameter to the filesystem show Anand Jain
2013-10-15 17:22 ` David Sterba
2013-10-16 2:22 ` Anand Jain
2013-10-08 3:41 ` [PATCH 3/3] btrfs-progs: use BTRFS_SCAN_LBLKID as default scan in " Anand Jain
2013-10-15 17:13 ` [PATCH 1/3 v4] btrfs-progs: use kernel for mounted disk for show David Sterba
2013-10-16 9:25 ` Anand Jain
2013-10-16 13:09 ` David Sterba
2013-10-21 14:44 ` Josef Bacik
2013-10-22 5:53 ` Anand Jain
2013-10-22 13:21 ` Josef Bacik
2013-10-22 13:28 ` Hugo Mills [this message]
2013-10-22 16:52 ` David Sterba
2013-10-23 11:20 ` Anand Jain
2013-10-23 11:41 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022132831.GH6598@carfax.org.uk \
--to=hugo@carfax.org.uk \
--cc=Anand.Jain@oracle.com \
--cc=chris.mason@fusionio.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).