From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz,
chris.mason@fusionio.com, jbacik@fusionio.com
Subject: Re: [PATCH 2/2] btrfs-progs: filesystem show of specified mounted disk should work
Date: Tue, 22 Oct 2013 16:33:03 +0200 [thread overview]
Message-ID: <20131022143303.GU1032@twin.jikos.cz> (raw)
In-Reply-To: <1382421202-18494-2-git-send-email-anand.jain@oracle.com>
On Tue, Oct 22, 2013 at 01:53:22PM +0800, Anand Jain wrote:
> @@ -386,7 +395,7 @@ static int btrfs_scan_kernel(void *search)
> static const char * const cmd_show_usage[] = {
> - "btrfs filesystem show [options] [<path>|<uuid>]",
> + "btrfs filesystem show [options|<path>|<uuid>]",
Options should stay separate from the path/uuid, you're extending the
syntax to accept a device:
"btrfs filesystem show [options] [<path>|<uuid>|<device>]",
I'm fixing it locally, let me know if this doesn't match what you've
intended.
david
next prev parent reply other threads:[~2013-10-22 14:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 5:53 [PATCH 1/2] btrfs-progs: make get_btrfs_mount callable Anand Jain
2013-10-22 5:53 ` [PATCH 2/2] btrfs-progs: filesystem show of specified mounted disk should work Anand Jain
2013-10-22 14:33 ` David Sterba [this message]
2013-10-23 2:08 ` Anand Jain
2013-10-24 14:51 ` David Sterba
2013-10-24 14:54 ` Hugo Mills
2013-10-24 17:21 ` Anand Jain
2013-10-22 16:39 ` David Sterba
2013-10-23 1:53 ` Anand Jain
2013-10-22 14:43 ` [PATCH 1/2] btrfs-progs: make get_btrfs_mount callable David Sterba
2013-10-23 2:11 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022143303.GU1032@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=chris.mason@fusionio.com \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).