From: Josef Bacik <jbacik@fusionio.com>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Josef Bacik <jbacik@fusionio.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [patch 00/13] sysfs publishing patchset
Date: Tue, 22 Oct 2013 16:43:29 -0400 [thread overview]
Message-ID: <20131022204329.GA10632@localhost.localdomain> (raw)
In-Reply-To: <5266C64A.90506@suse.com>
On Tue, Oct 22, 2013 at 02:39:06PM -0400, Jeff Mahoney wrote:
> On 10/22/13 2:26 PM, Josef Bacik wrote:
> > On Mon, Oct 21, 2013 at 05:19:40PM -0400, Jeff Mahoney wrote:
> >> This patchset implements the stubbed-out sysfs interface for btrfs. Or
> >> at least begins to do so.
> >>
> >> We publish:
> >> - Features supported by the file system implementation
> >> - Features enabled on the file system, including features unknown to
> >> the implemenation. These attributes can also be used to enable or
> >> disable features at runtime, subjecting to a safety mask.
> >> - Uses the attribute names to print feature names when declining to
> >> mount a file system.
> >> - The allocation data: global metadata reservation size and reserved,
> >> space_infos, and sums of the block groups total and used bytes.
> >> - Device membership via links to the block devices.
> >> - FS label, which is writeable.
> >>
> >> - I've also added matching ioctls for some of the functionality here so
> >> that btrfsprogs can use the information without jumping through hoops
> >> to read/parse the sysfs files. There are ioctls to query the supported
> >> features and to query/set features on a particular file system. There's
> >> also one to export the size of the global metadata reservation. I have
> >> a patch for btrfs-progs that uses this to print useful info in 'btrfs
> >> fi df' output.
> >>
> >> Ultimately, the tree structure looks like the following, under /sys/fs/btrfs.
> >> This is from a test file system, using two devices in raid1. You'll notice
> >> the 'single' and 'raid1' directories under the {data,metadata,system} dirs.
> >> The raid profiles are created and removed as the first/last block group
> >> of a certain profile is added and removed.
> >>
> >
> > I'm not pulling in patches that add new functionality without an accompanying
> > xfstest so that we're not merging features without a way to test to make sure
>
> Sure, that's reasonable.
>
> > they are working properly, this applies to the global metadata reservation ioctl
> > as well. Thanks,
>
> What would a test look like for that? It's information that isn't
> currently available anywhere in userspace and isn't represented in the
> file system itself.
>
I thought it did more than what it did, but still I'd like a sanity check, so
maybe mkfs and mount a scratch dev and make sure it comes back with > 0 and less
than say 10mb? Thanks,
Josef
next prev parent reply other threads:[~2013-10-22 20:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 21:19 [patch 00/13] sysfs publishing patchset Jeff Mahoney
2013-10-21 21:19 ` [patch 01/13] btrfs: add ioctls to query/change feature bits online Jeff Mahoney
2013-10-21 21:19 ` [patch 02/13] kobject: export kobj_sysfs_ops Jeff Mahoney
2013-10-22 14:44 ` Jeff Mahoney
2013-10-21 21:19 ` [patch 03/13] btrfs: publish supported featured in sysfs Jeff Mahoney
2013-10-21 21:19 ` [patch 04/13] btrfs: publish per-super attributes " Jeff Mahoney
2013-10-21 21:19 ` [patch 05/13] btrfs: publish per-super features " Jeff Mahoney
2013-10-21 21:19 ` [patch 06/13] btrfs: publish unknown feature bits " Jeff Mahoney
2013-10-21 21:19 ` [patch 07/13] btrfs: add ability to change features via sysfs Jeff Mahoney
2013-10-21 21:19 ` [patch 08/13] btrfs: use feature attribute names to print better error messages Jeff Mahoney
2013-10-21 21:19 ` [patch 09/13] btrfs: add ioctl to export size of global metadata reservation Jeff Mahoney
2013-10-21 21:19 ` [patch 10/13] btrfs: publish allocation data in sysfs Jeff Mahoney
2013-10-29 18:49 ` Jeff Mahoney
2013-10-21 21:19 ` [patch 11/13] btrfs: publish device membership " Jeff Mahoney
2013-10-21 21:19 ` [patch 12/13] btrfs: publish fs label " Jeff Mahoney
2013-10-21 21:19 ` [patch 13/13] btrfs: add tracing for failed reservations Jeff Mahoney
2013-10-22 18:26 ` [patch 00/13] sysfs publishing patchset Josef Bacik
2013-10-22 18:39 ` Jeff Mahoney
2013-10-22 20:43 ` Josef Bacik [this message]
2013-10-29 18:25 ` Goffredo Baroncelli
2013-10-29 20:26 ` Jeff Mahoney
2013-10-29 21:57 ` Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022204329.GA10632@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).