From: Eryu Guan <eguan@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] xfstests btrfs/020: test device replace on RO btrfs
Date: Thu, 24 Oct 2013 00:41:36 +0800 [thread overview]
Message-ID: <20131023164136.GI2675@dhcp-13-216.nay.redhat.com> (raw)
In-Reply-To: <5267F88E.1010607@redhat.com>
On Wed, Oct 23, 2013 at 11:25:50AM -0500, Eric Sandeen wrote:
> On 10/23/13 6:24 AM, Eryu Guan wrote:
> > btrfs replace on readonly fs should not be allowed.
> >
> > Regression test case for commit:
> > bbb651e Btrfs: don't allow the replace procedure on read only filesystems
> >
> > Signed-off-by: Eryu Guan <eguan@redhat.com>
>
> Could you speed this up by just truncating the loop files to 256m, rather
> than writing 256m to each (for a total of 768m IO?)
Sure, and that does save much time, 7s -> 1s on my test box.
V2 will be coming soon.
Thanks for the review!
Eryu
next prev parent reply other threads:[~2013-10-23 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 11:24 [PATCH] xfstests btrfs/020: test device replace on RO btrfs Eryu Guan
2013-10-23 16:25 ` Eric Sandeen
2013-10-23 16:41 ` Eryu Guan [this message]
2013-10-23 16:44 ` [PATCH v2] " Eryu Guan
2013-10-23 17:05 ` Stefan Behrens
2013-10-23 17:45 ` Eric Sandeen
2013-10-23 21:43 ` Dave Chinner
2013-10-23 17:45 ` Eric Sandeen
2013-10-24 10:17 ` David Sterba
2013-10-24 0:14 ` [PATCH] " Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023164136.GI2675@dhcp-13-216.nay.redhat.com \
--to=eguan@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).