From: David Sterba <dsterba@suse.cz>
To: Mitch Harder <mitch.harder@sabayonlinux.org>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>,
Miao Xie <miaox@cn.fujitsu.com>
Subject: Re: [PATCH 3/3] btrfs-progs: separate command ant implementation of chunk-recover code
Date: Fri, 25 Oct 2013 12:00:46 +0200 [thread overview]
Message-ID: <20131025100046.GD28149@suse.cz> (raw)
In-Reply-To: <CAKcLGm9tCpw--Omat+f8GoVUHzOA98FTq-mgFzLa=+Y=WH_w+w@mail.gmail.com>
On Thu, Oct 24, 2013 at 03:31:55PM -0500, Mitch Harder wrote:
> On Tue, Sep 17, 2013 at 10:21 AM, David Sterba <dsterba@suse.cz> wrote:
> > The command has been moved and we should rename the files accordingly,
> > so the entry point is now in cmds-rescue.c and the core functionality
> > in it's own file.
> >
> > Return codes of btrfs_recover_chunk_tree have been simplified not to
> > require a define and another file for defintion.
> >
> > CC: Miao Xie <miaox@cn.fujitsu.com>
> > Signed-off-by: David Sterba <dsterba@suse.cz>
> > ---
> > Makefile | 3 +-
> > chunk-recover.c | 1745 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > cmds-rescue.c | 62 ++
> > 3 files changed, 1809 insertions(+), 1 deletion(-)
> > create mode 100644 chunk-recover.c
>
> I'm not sure if this patch has gone 'final' yet, but since it
> relocates the code from cmds-chunk.c to chunk-recover.c, the
> cmds-chunk.c file needs to be deleted.
Right, thanks for noticing.
david
prev parent reply other threads:[~2013-10-25 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 15:21 [PATCH 0/3] btrfs-progs: Add command group for rescue operations David Sterba
2013-09-17 15:21 ` [PATCH 1/3] btrfs-progs: introduce rescue command group David Sterba
2013-09-17 15:21 ` [PATCH 2/3] btrfs-progs: move chunk-recover to rescue group David Sterba
2013-09-17 15:21 ` [PATCH 3/3] btrfs-progs: separate command ant implementation of chunk-recover code David Sterba
2013-10-24 20:31 ` Mitch Harder
2013-10-25 10:00 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025100046.GD28149@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=mitch.harder@sabayonlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).