From: Josef Bacik <jbacik@fusionio.com>
To: Martin <m_btrfs@ml1.co.uk>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs-progs: allow --init-extent-tree to work when extent tree is borked
Date: Mon, 28 Oct 2013 11:11:48 -0400 [thread overview]
Message-ID: <20131028151148.GB4543@localhost.localdomain> (raw)
In-Reply-To: <l4hifj$ni1$1@ger.gmane.org>
On Sun, Oct 27, 2013 at 12:16:12AM +0100, Martin wrote:
> On 25/10/13 19:31, Josef Bacik wrote:
> > On Fri, Oct 25, 2013 at 07:27:24PM +0100, Martin wrote:
> >> On 25/10/13 19:01, Josef Bacik wrote:
> >>> Unfortunately you can't run --init-extent-tree if you can't actually read the
> >>> extent root. Fix this by allowing partial starts with no extent root and then
> >>> have fsck only check to see if the extent root is uptodate _after_ the check to
> >>> see if we are init'ing the extent tree. Thanks,
> >>>
> >>> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
> >>> ---
> >>> cmds-check.c | 9 ++++++---
> >>> disk-io.c | 16 ++++++++++++++--
> >>> 2 files changed, 20 insertions(+), 5 deletions(-)
> >>>
> >>> diff --git a/cmds-check.c b/cmds-check.c
> >>> index 69b0327..8ed7baa 100644
> >>> --- a/cmds-check.c
> >>> +++ b/cmds-check.c
> >>
> >> Hey! Quick work!...
> >>
> >> Is that worth patching locally and trying against my example?
> >>
> >
> > Yes, I'm a little worried about your particular case so I'd like to see if it
> > works. If you don't see a lot of output after say 5 minutes let's assume I
> > didn't fix your problem and let me know so I can make the other change I
> > considered. Thanks,
>
> Nope... No-go.
>
Ok I've sent
[PATCH] Btrfs-progs: rework open_ctree to take flags, add a new one
which should address your situation. Thanks,
Josef
next prev parent reply other threads:[~2013-10-28 15:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 18:01 [PATCH] Btrfs-progs: allow --init-extent-tree to work when extent tree is borked Josef Bacik
2013-10-25 18:27 ` Martin
2013-10-25 18:31 ` Josef Bacik
2013-10-26 23:16 ` Martin
2013-10-27 1:44 ` Josef Back
2013-10-28 15:11 ` Josef Bacik [this message]
2013-11-07 1:25 ` Martin
2013-11-11 22:52 ` Martin
2013-11-13 12:08 ` Martin
2013-11-13 13:46 ` Duncan
2013-11-15 17:18 ` Martin
2013-11-19 6:34 ` Martin
2013-11-20 6:51 ` btrfsck --repair /dev/sdc (Was: [PATCH] Btrfs-progs: allow --init-extent-tree to work when extent tree is borked) Martin
2013-11-20 17:08 ` Duncan
2013-11-20 20:00 ` Martin
2013-11-25 23:18 ` Martin
2013-11-27 6:29 ` Martin
2013-11-20 20:03 ` Martin
2013-11-19 6:25 ` [PATCH] Btrfs-progs: allow --init-extent-tree to work when extent tree is borked Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028151148.GB4543@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=m_btrfs@ml1.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).