From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dkim1.fusionio.com ([66.114.96.53]:46448 "EHLO dkim1.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932260Ab3J1PLw (ORCPT ); Mon, 28 Oct 2013 11:11:52 -0400 Received: from mx2.fusionio.com (unknown [10.101.1.160]) by dkim1.fusionio.com (Postfix) with ESMTP id BF7FC7C064D for ; Mon, 28 Oct 2013 09:11:51 -0600 (MDT) Date: Mon, 28 Oct 2013 11:11:48 -0400 From: Josef Bacik To: Martin CC: Subject: Re: [PATCH] Btrfs-progs: allow --init-extent-tree to work when extent tree is borked Message-ID: <20131028151148.GB4543@localhost.localdomain> References: <1382724100-5276-1-git-send-email-jbacik@fusionio.com> <20131025183134.GA4543@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Sun, Oct 27, 2013 at 12:16:12AM +0100, Martin wrote: > On 25/10/13 19:31, Josef Bacik wrote: > > On Fri, Oct 25, 2013 at 07:27:24PM +0100, Martin wrote: > >> On 25/10/13 19:01, Josef Bacik wrote: > >>> Unfortunately you can't run --init-extent-tree if you can't actually read the > >>> extent root. Fix this by allowing partial starts with no extent root and then > >>> have fsck only check to see if the extent root is uptodate _after_ the check to > >>> see if we are init'ing the extent tree. Thanks, > >>> > >>> Signed-off-by: Josef Bacik > >>> --- > >>> cmds-check.c | 9 ++++++--- > >>> disk-io.c | 16 ++++++++++++++-- > >>> 2 files changed, 20 insertions(+), 5 deletions(-) > >>> > >>> diff --git a/cmds-check.c b/cmds-check.c > >>> index 69b0327..8ed7baa 100644 > >>> --- a/cmds-check.c > >>> +++ b/cmds-check.c > >> > >> Hey! Quick work!... > >> > >> Is that worth patching locally and trying against my example? > >> > > > > Yes, I'm a little worried about your particular case so I'd like to see if it > > works. If you don't see a lot of output after say 5 minutes let's assume I > > didn't fix your problem and let me know so I can make the other change I > > considered. Thanks, > > Nope... No-go. > Ok I've sent [PATCH] Btrfs-progs: rework open_ctree to take flags, add a new one which should address your situation. Thanks, Josef