linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fusionio.com>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: Josef Bacik <jbacik@fusionio.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: check file extent type before anything else
Date: Fri, 1 Nov 2013 08:40:34 -0400	[thread overview]
Message-ID: <20131101124034.GC16855@localhost.localdomain> (raw)
In-Reply-To: <527358A4.9060003@giantdisaster.de>

On Fri, Nov 01, 2013 at 08:30:44AM +0100, Stefan Behrens wrote:
> On Thu, 31 Oct 2013 16:50:43 -0400, Josef Bacik wrote:
> > I hit this problem with my no holes patch and it made me realize what the
> > problem was for bz 60834.  If the first item in the leaf is an inline extent and
> > we try to read anything starting from disk_bytenr onward we will read off the
> > end of the leaf.  So we need to check to see what it's type is, and if it's not
> > REG we can just break out.  This should fix this problem.  Thanks,
> > 
> > Signed-off-by: Josef Bacik <jbacik@fusionio.com>
> > ---
> >  fs/btrfs/backref.c |  1 +
> >  fs/btrfs/send.c    | 10 +++++-----
> >  2 files changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> > index 3775947..b763f10 100644
> > --- a/fs/btrfs/backref.c
> > +++ b/fs/btrfs/backref.c
> > @@ -1051,6 +1051,7 @@ static int btrfs_find_all_leafs(struct btrfs_trans_handle *trans,
> >  
> >  	if (ret < 0 && ret != -ENOENT) {
> >  		free_leaf_list(*leafs);
> > +		ulist_free(*leafs);
> 
> An en passant fix for which problem?
> 

Oops, sorry about that, not a problem just me doing other things, I'll drop that
bit.  Thanks,

Josef

      reply	other threads:[~2013-11-01 12:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31 20:50 [PATCH] Btrfs: check file extent type before anything else Josef Bacik
2013-11-01  7:30 ` Stefan Behrens
2013-11-01 12:40   ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131101124034.GC16855@localhost.localdomain \
    --to=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sbehrens@giantdisaster.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).