* [PATCH] FS: BTRFS: fixed coding style issues
@ 2013-11-04 13:27 Aldo Iljazi
2013-11-04 15:16 ` David Sterba
2013-11-05 10:28 ` David Sterba
0 siblings, 2 replies; 9+ messages in thread
From: Aldo Iljazi @ 2013-11-04 13:27 UTC (permalink / raw)
To: chris.mason; +Cc: linux-btrfs, linux-kernel
Fixed three coding style issues. Replaced spaces with tabs.
Signed-off-by: Aldo Iljazi <mail@aldo.io>
---
fs/btrfs/dev-replace.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index 9efb94e..b2fe609 100644
--- a/fs/btrfs/dev-replace.c
+++ b/fs/btrfs/dev-replace.c
@@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
printk_in_rcu(KERN_INFO
"btrfs: dev_replace from %s (devid %llu) to %s) started\n",
src_device->missing ? "<missing disk>" :
- rcu_str_deref(src_device->name),
+ rcu_str_deref(src_device->name),
src_device->devid,
rcu_str_deref(tgt_device->name));
@@ -500,7 +500,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
printk_in_rcu(KERN_ERR
"btrfs: btrfs_scrub_dev(%s, %llu, %s) failed %d\n",
src_device->missing ? "<missing disk>" :
- rcu_str_deref(src_device->name),
+ rcu_str_deref(src_device->name),
src_device->devid,
rcu_str_deref(tgt_device->name), scrub_ret);
btrfs_dev_replace_unlock(dev_replace);
@@ -515,7 +515,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
printk_in_rcu(KERN_INFO
"btrfs: dev_replace from %s (devid %llu) to %s) finished\n",
src_device->missing ? "<missing disk>" :
- rcu_str_deref(src_device->name),
+ rcu_str_deref(src_device->name),
src_device->devid,
rcu_str_deref(tgt_device->name));
tgt_device->is_tgtdev_for_dev_replace = 0;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] FS: BTRFS: fixed coding style issues
2013-11-04 13:27 [PATCH] FS: BTRFS: fixed coding style issues Aldo Iljazi
@ 2013-11-04 15:16 ` David Sterba
2013-11-12 16:57 ` Aldo Iljazi
2013-11-05 10:28 ` David Sterba
1 sibling, 1 reply; 9+ messages in thread
From: David Sterba @ 2013-11-04 15:16 UTC (permalink / raw)
To: Aldo Iljazi; +Cc: chris.mason, linux-btrfs, linux-kernel
On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote:
> Fixed three coding style issues. Replaced spaces with tabs.
>
> Signed-off-by: Aldo Iljazi <mail@aldo.io>
> ---
> fs/btrfs/dev-replace.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> index 9efb94e..b2fe609 100644
> --- a/fs/btrfs/dev-replace.c
> +++ b/fs/btrfs/dev-replace.c
> @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
> printk_in_rcu(KERN_INFO
> "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
> src_device->missing ? "<missing disk>" :
> - rcu_str_deref(src_device->name),
> + rcu_str_deref(src_device->name),
What's the change here? I don't think we need to fix whitespace, this
makes searching in patch history more boring, namely in case where the
code looks exactly the same before and after the patch.
The style issues should be best fixed when the patch is about to be
merged, doing it later like this is kind of not welcome, speaking for
myself. There are lots of opportunities to do real code cleanups.
david
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] FS: BTRFS: fixed coding style issues
2013-11-04 15:16 ` David Sterba
@ 2013-11-12 16:57 ` Aldo Iljazi
0 siblings, 0 replies; 9+ messages in thread
From: Aldo Iljazi @ 2013-11-12 16:57 UTC (permalink / raw)
To: dsterba, chris.mason, linux-btrfs, linux-kernel
David Sterba wrote:
> On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote:
> > Fixed three coding style issues. Replaced spaces with tabs.
> >
> > Signed-off-by: Aldo Iljazi <mail@aldo.io>
> > ---
> > fs/btrfs/dev-replace.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> > index 9efb94e..b2fe609 100644
> > --- a/fs/btrfs/dev-replace.c
> > +++ b/fs/btrfs/dev-replace.c
> > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
> > printk_in_rcu(KERN_INFO
> > "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
> > src_device->missing ? "<missing disk>" :
> > - rcu_str_deref(src_device->name),
> > + rcu_str_deref(src_device->name),
>
> What's the change here? I don't think we need to fix whitespace, this
> makes searching in patch history more boring, namely in case where the
> code looks exactly the same before and after the patch.
>
> The style issues should be best fixed when the patch is about to be
> merged, doing it later like this is kind of not welcome, speaking for
> myself. There are lots of opportunities to do real code cleanups.
>
>
> david
Okay thanks.
--
Aldo Iljazi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] FS: BTRFS: fixed coding style issues
2013-11-04 13:27 [PATCH] FS: BTRFS: fixed coding style issues Aldo Iljazi
2013-11-04 15:16 ` David Sterba
@ 2013-11-05 10:28 ` David Sterba
2013-11-05 10:32 ` Aldo Iljazi
1 sibling, 1 reply; 9+ messages in thread
From: David Sterba @ 2013-11-05 10:28 UTC (permalink / raw)
To: Aldo Iljazi; +Cc: chris.mason, linux-btrfs, linux-kernel
On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote:
> Fixed three coding style issues. Replaced spaces with tabs.
>
> Signed-off-by: Aldo Iljazi <mail@aldo.io>
> ---
> fs/btrfs/dev-replace.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> index 9efb94e..b2fe609 100644
> --- a/fs/btrfs/dev-replace.c
> +++ b/fs/btrfs/dev-replace.c
> @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
> printk_in_rcu(KERN_INFO
> "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
> src_device->missing ? "<missing disk>" :
> - rcu_str_deref(src_device->name),
> + rcu_str_deref(src_device->name),
What's the change here? I don't think we need to fix whitespace, this makes
searching in patch history more tedious, namely in case where the code looks
exactly the same before and after the patch.
The style issues should be best fixed when the patch is about to be
merged, doing it later like this is kind of not welcome, speaking for
myself. There are lots of opportunities to do real code cleanups.
Whitespace changes are just noise, we don't need them at this point of
development phase of btrfs.
david
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] FS: BTRFS: fixed coding style issues
2013-11-05 10:28 ` David Sterba
@ 2013-11-05 10:32 ` Aldo Iljazi
2013-11-05 10:36 ` David Sterba
0 siblings, 1 reply; 9+ messages in thread
From: Aldo Iljazi @ 2013-11-05 10:32 UTC (permalink / raw)
To: dsterba, chris.mason, linux-btrfs, linux-kernel
David Sterba wrote:
> On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote:
> > Fixed three coding style issues. Replaced spaces with tabs.
> >
> > Signed-off-by: Aldo Iljazi <mail@aldo.io>
> > ---
> > fs/btrfs/dev-replace.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> > index 9efb94e..b2fe609 100644
> > --- a/fs/btrfs/dev-replace.c
> > +++ b/fs/btrfs/dev-replace.c
> > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
> > printk_in_rcu(KERN_INFO
> > "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
> > src_device->missing ? "<missing disk>" :
> > - rcu_str_deref(src_device->name),
> > + rcu_str_deref(src_device->name),
>
> What's the change here? I don't think we need to fix whitespace, this makes
> searching in patch history more tedious, namely in case where the code looks
> exactly the same before and after the patch.
>
> The style issues should be best fixed when the patch is about to be
> merged, doing it later like this is kind of not welcome, speaking for
> myself. There are lots of opportunities to do real code cleanups.
>
> Whitespace changes are just noise, we don't need them at this point of
> development phase of btrfs.
>
>
> david
I replaced the spaces with tabs, as the kernel coding style suggests.
--
Aldo Iljazi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] FS: BTRFS: fixed coding style issues
2013-11-05 10:32 ` Aldo Iljazi
@ 2013-11-05 10:36 ` David Sterba
2013-11-05 10:40 ` Aldo Iljazi
0 siblings, 1 reply; 9+ messages in thread
From: David Sterba @ 2013-11-05 10:36 UTC (permalink / raw)
To: Aldo Iljazi; +Cc: dsterba, chris.mason, linux-btrfs, linux-kernel
On Tue, Nov 05, 2013 at 12:32:37PM +0200, Aldo Iljazi wrote:
> David Sterba wrote:
>
> > On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote:
> > > Fixed three coding style issues. Replaced spaces with tabs.
> > >
> > > Signed-off-by: Aldo Iljazi <mail@aldo.io>
> > > ---
> > > fs/btrfs/dev-replace.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> > > index 9efb94e..b2fe609 100644
> > > --- a/fs/btrfs/dev-replace.c
> > > +++ b/fs/btrfs/dev-replace.c
> > > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
> > > printk_in_rcu(KERN_INFO
> > > "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
> > > src_device->missing ? "<missing disk>" :
> > > - rcu_str_deref(src_device->name),
> > > + rcu_str_deref(src_device->name),
> >
> > What's the change here? I don't think we need to fix whitespace, this makes
> > searching in patch history more tedious, namely in case where the code looks
> > exactly the same before and after the patch.
> >
> > The style issues should be best fixed when the patch is about to be
> > merged, doing it later like this is kind of not welcome, speaking for
> > myself. There are lots of opportunities to do real code cleanups.
> >
> > Whitespace changes are just noise, we don't need them at this point of
> > development phase of btrfs.
> >
> >
> > david
>
> I replaced the spaces with tabs, as the kernel coding style suggests.
I repeat:
Whitespace changes are just noise, we don't need them at this point of
development phase of btrfs.
david
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] FS: BTRFS: fixed coding style issues
2013-11-05 10:36 ` David Sterba
@ 2013-11-05 10:40 ` Aldo Iljazi
2013-11-05 11:36 ` David Sterba
0 siblings, 1 reply; 9+ messages in thread
From: Aldo Iljazi @ 2013-11-05 10:40 UTC (permalink / raw)
To: dsterba, chris.mason, linux-btrfs, linux-kernel
David Sterba wrote:
> On Tue, Nov 05, 2013 at 12:32:37PM +0200, Aldo Iljazi wrote:
> > David Sterba wrote:
> >
> > > On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote:
> > > > Fixed three coding style issues. Replaced spaces with tabs.
> > > >
> > > > Signed-off-by: Aldo Iljazi <mail@aldo.io>
> > > > ---
> > > > fs/btrfs/dev-replace.c | 6 +++---
> > > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> > > > index 9efb94e..b2fe609 100644
> > > > --- a/fs/btrfs/dev-replace.c
> > > > +++ b/fs/btrfs/dev-replace.c
> > > > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
> > > > printk_in_rcu(KERN_INFO
> > > > "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
> > > > src_device->missing ? "<missing disk>" :
> > > > - rcu_str_deref(src_device->name),
> > > > + rcu_str_deref(src_device->name),
> > >
> > > What's the change here? I don't think we need to fix whitespace, this makes
> > > searching in patch history more tedious, namely in case where the code looks
> > > exactly the same before and after the patch.
> > >
> > > The style issues should be best fixed when the patch is about to be
> > > merged, doing it later like this is kind of not welcome, speaking for
> > > myself. There are lots of opportunities to do real code cleanups.
> > >
> > > Whitespace changes are just noise, we don't need them at this point of
> > > development phase of btrfs.
> > >
> > >
> > > david
> >
> > I replaced the spaces with tabs, as the kernel coding style suggests.
>
> I repeat:
>
> Whitespace changes are just noise, we don't need them at this point of
> development phase of btrfs.
>
> david
Okay then ignore the patch.
--
Aldo Iljazi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] FS: BTRFS: fixed coding style issues
2013-11-05 10:40 ` Aldo Iljazi
@ 2013-11-05 11:36 ` David Sterba
2013-11-05 12:32 ` Aldo Iljazi
0 siblings, 1 reply; 9+ messages in thread
From: David Sterba @ 2013-11-05 11:36 UTC (permalink / raw)
To: Aldo Iljazi; +Cc: dsterba, chris.mason, linux-btrfs, linux-kernel
On Tue, Nov 05, 2013 at 12:40:16PM +0200, Aldo Iljazi wrote:
> > > I replaced the spaces with tabs, as the kernel coding style suggests.
> >
> > I repeat:
> >
> > Whitespace changes are just noise, we don't need them at this point of
> > development phase of btrfs.
> >
> > david
>
> Okay then ignore the patch.
Well, this also applies to patches with subject 'BTRFS: fixed coding style issues'
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] FS: BTRFS: fixed coding style issues
2013-11-05 11:36 ` David Sterba
@ 2013-11-05 12:32 ` Aldo Iljazi
0 siblings, 0 replies; 9+ messages in thread
From: Aldo Iljazi @ 2013-11-05 12:32 UTC (permalink / raw)
To: dsterba, chris.mason, linux-btrfs, linux-kernel
David Sterba wrote:
> On Tue, Nov 05, 2013 at 12:40:16PM +0200, Aldo Iljazi wrote:
> > > > I replaced the spaces with tabs, as the kernel coding style suggests.
> > >
> > > I repeat:
> > >
> > > Whitespace changes are just noise, we don't need them at this point of
> > > development phase of btrfs.
> > >
> > > david
> >
> > Okay then ignore the patch.
>
> Well, this also applies to patches with subject 'BTRFS: fixed coding style issues'
Okay then.
--
Aldo Iljazi
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-11-12 16:57 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-04 13:27 [PATCH] FS: BTRFS: fixed coding style issues Aldo Iljazi
2013-11-04 15:16 ` David Sterba
2013-11-12 16:57 ` Aldo Iljazi
2013-11-05 10:28 ` David Sterba
2013-11-05 10:32 ` Aldo Iljazi
2013-11-05 10:36 ` David Sterba
2013-11-05 10:40 ` Aldo Iljazi
2013-11-05 11:36 ` David Sterba
2013-11-05 12:32 ` Aldo Iljazi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).