From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dkim1.fusionio.com ([66.114.96.53]:49961 "EHLO dkim1.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822Ab3KGSJ6 (ORCPT ); Thu, 7 Nov 2013 13:09:58 -0500 Received: from mx2.fusionio.com (unknown [10.101.1.160]) by dkim1.fusionio.com (Postfix) with ESMTP id 6887F7C0682 for ; Thu, 7 Nov 2013 11:09:58 -0700 (MST) Date: Thu, 7 Nov 2013 13:09:56 -0500 From: Josef Bacik To: Josef Bacik CC: Qu Wenruo , Subject: Re: [PATCH v3 02/17] btrfs: Added btrfs_workqueue_struct implemented ordered execution based on kernel workqueue Message-ID: <20131107180956.GJ27784@localhost.localdomain> References: <1383803527-23736-1-git-send-email-quwenruo@cn.fujitsu.com> <1383803527-23736-3-git-send-email-quwenruo@cn.fujitsu.com> <20131107180826.GI27784@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20131107180826.GI27784@localhost.localdomain> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, Nov 07, 2013 at 01:08:26PM -0500, Josef Bacik wrote: > On Thu, Nov 07, 2013 at 01:51:52PM +0800, Qu Wenruo wrote: > > Use kernel workqueue to implement a new btrfs_workqueue_struct, which > > has the ordering execution feature like the btrfs_worker. > > > > The func is executed in a concurrency way, and the > > ordred_func/ordered_free is executed in the sequence them are queued > > after the corresponding func is done. > > The new btrfs_workqueue use 2 workqueues to implement the original > > btrfs_worker, one for the normal work and one for ordered work. > > > > At this patch, high priority work queue or thresholding is not added yet. > > The high priority feature and thresholding will be added in the following patches. > > > > Signed-off-by: Qu Wenruo > > Reviewed-by: Josef Bacik > Keep in mind I agree with Stefan and Dave's comments so please make those changes, but after that you can add my reviewed by. Thanks, Josef