From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dkim1.fusionio.com ([66.114.96.53]:40252 "EHLO dkim1.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065Ab3KONk0 convert rfc822-to-8bit (ORCPT ); Fri, 15 Nov 2013 08:40:26 -0500 Received: from mx2.fusionio.com (unknown [10.101.1.160]) by dkim1.fusionio.com (Postfix) with ESMTP id EDCA87C06F1 for ; Fri, 15 Nov 2013 06:40:25 -0700 (MST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: Heiko Carstens From: Chris Mason In-Reply-To: <20131115122131.3802.25439@localhost.localdomain> CC: Linus Torvalds , , lkml , Dulshani Gunawardhana , Gleb Natapov , Paolo Bonzini , Mark Brown References: <20131114171952.3802.93244@localhost.localdomain> <20131115113216.GA7777@osiris> <20131115122131.3802.25439@localhost.localdomain> Message-ID: <20131115134019.3802.51473@localhost.localdomain> Subject: Re: [GIT PULL] Btrfs Date: Fri, 15 Nov 2013 08:40:19 -0500 Sender: linux-btrfs-owner@vger.kernel.org List-ID: Quoting Chris Mason (2013-11-15 07:21:31) > Quoting Heiko Carstens (2013-11-15 06:32:16) > > On Thu, Nov 14, 2013 at 12:19:52PM -0500, Chris Mason wrote: > > > Hi Linus, > > > > > > Please pull my for-linus branch: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus > > > > > > This is our usual merge window set of bug fixes, performance > > > improvements and cleanups. Miao Xie has some really nice optimizations > > > for writeback. > > > > > > Josef also expanded our sanity checks quite a bit; these make up a big > > > chunk of the new lines. > > > > Hmm.. b19e68439375 "btrfs: Remove redundant local zero structure" seems to > > use the empty_zero_page incorrectly and causes this compile warning on s390: > > > > CC fs/btrfs/ioctl.o > > fs/btrfs/ioctl.c: In function 'btrfs_is_empty_uuid': > > fs/btrfs/ioctl.c:372:2: warning: passing argument 2 of 'memcmp' makes pointer from > > integer without a cast [enabled by default] > > return !memcmp(uuid, empty_zero_page, BTRFS_UUID_SIZE); > > ^ > > > > In fact there seem to be two more incorrect usages in the kernel. The patch > > below is not really tested. > > Thanks Heiko, > > I'll make a new pull with the btrfs part of this. Or something slightly different ;) BUG: unable to handle kernel paging request at 0000000001ba6000 IP: [] memcmp+0xf/0x22 -chris