From: David Sterba <dsterba@suse.cz>
To: Goffredo Baroncelli <kreijack@gmail.com>
Cc: linux-btrfs@vger.kernel.org, Goffredo Baroncelli <kreijack@inwind.it>
Subject: Re: [PATCH] Prefix with "ERROR:" the error messages of mkfs
Date: Fri, 15 Nov 2013 15:56:41 +0100 [thread overview]
Message-ID: <20131115145641.GA8035@twin.jikos.cz> (raw)
In-Reply-To: <1384511376-14740-2-git-send-email-kreijack@inwind.it>
On Fri, Nov 15, 2013 at 11:29:36AM +0100, Goffredo Baroncelli wrote:
> Add the ERROR prefix to the error messages of mkfs, to align it
> to the btrfs main utility style.
>
> The patch increase the buffer size of test_dev_for_mkfs() and
> test_num_disk_vs_raid() for the error message from 100 to 150
> because the former become too small.
This was discussed some time ago, that the error message should not be
passed that way via caller-provided variable.
I'd tend to take this patch now because of the improved messages.
prev parent reply other threads:[~2013-11-15 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 10:29 [PATCH] BTRFS-PROG: prefix with ERROR the mkfs error messages Goffredo Baroncelli
2013-11-15 10:29 ` [PATCH] Prefix with "ERROR:" the error messages of mkfs Goffredo Baroncelli
2013-11-15 14:56 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115145641.GA8035@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=kreijack@gmail.com \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).