linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fusionio.com>
To: Filipe David Borba Manana <fdmanana@gmail.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: avoid unnecessary ordered extent cache resets
Date: Fri, 22 Nov 2013 12:29:57 -0500	[thread overview]
Message-ID: <20131122172957.GC5349@localhost.localdomain> (raw)
In-Reply-To: <1385139163-7539-1-git-send-email-fdmanana@gmail.com>

On Fri, Nov 22, 2013 at 04:52:43PM +0000, Filipe David Borba Manana wrote:
> After an ordered extent completes, don't blindly reset the
> inode's ordered tree last accessed ordered extent pointer.
> 
> While running the xfstests I noticed that about 29% of the
> time the ordered extent to which tree->last pointed was not
> the same as our just completed ordered extent. After that I
> ran the following sysbench test (after a prepare phase) and
> noticed that about 68% of the time tree->last pointed to
> a different ordered extent too.
> 
> sysbench --test=fileio --file-num=32 --file-total-size=4G \
>     --file-test-mode=rndwr --num-threads=512 \
>     --file-block-size=32768 --max-time=60 --max-requests=0 run
> 
> Therefore reset tree->last on ordered extent removal only if
> it pointed to the ordered extent we're removing from the tree.
> 

Well this is excellent, how much does it affect performance tho?  I'm still
going to take it, I'd just like to know how big of an impact it makes.  Thanks,

Josef

  reply	other threads:[~2013-11-22 17:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22 16:52 [PATCH] Btrfs: avoid unnecessary ordered extent cache resets Filipe David Borba Manana
2013-11-22 17:29 ` Josef Bacik [this message]
2013-11-22 18:54 ` [PATCH v2] " Filipe David Borba Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131122172957.GC5349@localhost.localdomain \
    --to=jbacik@fusionio.com \
    --cc=fdmanana@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).