linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Mamedov <rm@romanrm.net>
To: Duncan <1i5t5.duncan@cox.net>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [virt-devel] btrfs NOCOW for VM disk images
Date: Sat, 23 Nov 2013 04:00:28 +0600	[thread overview]
Message-ID: <20131123040028.71a8ba4e@natsu> (raw)
In-Reply-To: <pan$25aa5$1906a260$3a199c05$d941ebdc@cox.net>

[-- Attachment #1: Type: text/plain, Size: 903 bytes --]

On Fri, 22 Nov 2013 21:26:16 +0000 (UTC)
Duncan <1i5t5.duncan@cox.net> wrote:

> > During testing I found that the NOCOW flag prevents file cloning from
> > working.  cp --reflink fails with EINVAL when the source file has the
> > NOCOW flag set.
> 
> That would be expected, since disabling COW means the file will be 
> updated in-place, and if reflink-copying was allowed, changing the one 
> view in-place would by definition change the other view of the same file, 
> since it /is/ the same file data.

However snapshotting a subvolume which has NOCOW files *is* allowed.
I'm told data is then COW'ed only once, and only the areas that are changed
after the snapshot has been made (or something along those lines). So since
snapshotting+NOCOW can be combined and everything works automagically as
expected, maybe reflink could be made to work as well?

-- 
With respect,
Roman

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2013-11-22 22:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20131122142051.GA32192@stefanha-thinkpad.redhat.com>
2013-11-22 16:17 ` Fwd: [virt-devel] btrfs NOCOW for VM disk images John Dulaney
2013-11-22 21:26   ` Duncan
2013-11-22 22:00     ` Roman Mamedov [this message]
2013-11-23  1:21       ` David Sterba
2013-11-22 22:12   ` Chris Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131123040028.71a8ba4e@natsu \
    --to=rm@romanrm.net \
    --cc=1i5t5.duncan@cox.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).