linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: dsterba@suse.cz, Josef Bacik <jbacik@fusionio.com>,
	linux-btrfs@vger.kernel.org, chris.mason@fusionio.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] Btrfs: relocate csums properly with prealloc extents
Date: Mon, 25 Nov 2013 13:01:04 -0800	[thread overview]
Message-ID: <20131125210104.GA24160@kroah.com> (raw)
In-Reply-To: <20131125165116.GR5007@twin.jikos.cz>

On Mon, Nov 25, 2013 at 05:51:16PM +0100, David Sterba wrote:
> On Fri, Sep 27, 2013 at 09:37:00AM -0400, Josef Bacik wrote:
> > A user reported a problem where they were getting csum errors when running a
> > balance and running systemd's journal.  This is because systemd is awesome and
> > fallocate()'s its log space and writes into it.  Unfortunately we assume that
> > when we read in all the csums for an extent that they are sequential starting at
> > the bytenr we care about.  This obviously isn't the case for prealloc extents,
> > where we could have written to the middle of the prealloc extent only, which
> > means the csum would be for the bytenr in the middle of our range and not the
> > front of our range.  Fix this by offsetting the new bytenr we are logging to
> > based on the original bytenr the csum was for.  With this patch I no longer see
> > the csum errors I was seeing.  Thanks,
> > 
> > Cc: stable@vger.kernel.org
> 
> The patch had the right CC but I don't see it in the mail's CC list (now
> added by me). I'm afraid that this never reached stable and explains why
> the patch did not end up in 3.12.1.

No, it made it to my list, I was waiting for 3.13-rc1 to come out with
this patch in it before I could queue it up.  Don't worry, it's not
lost.

thanks,

greg k-h

  reply	other threads:[~2013-11-25 21:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27 13:37 [PATCH] Btrfs: relocate csums properly with prealloc extents Josef Bacik
2013-10-04 21:19 ` Johannes Hirte
2013-10-23 21:24   ` Hans-Kristian Bakke
2013-10-23 21:49     ` Hans-Kristian Bakke
2013-10-24 16:19       ` Hans-Kristian Bakke
2013-10-24 14:08 ` [PATCH] Btrfs: relocate csums properly with prealloc extents - for 3.12-rc David Sterba
2013-11-25 16:51 ` [PATCH] Btrfs: relocate csums properly with prealloc extents David Sterba
2013-11-25 21:01   ` Greg KH [this message]
2013-11-30  7:39     ` Goffredo Baroncelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131125210104.GA24160@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chris.mason@fusionio.com \
    --cc=dsterba@suse.cz \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).