From: David Sterba <dsterba@suse.cz>
To: Goffredo Baroncelli <kreijack@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] BTRFS-PROG: recursively subvolume snapshot and delete
Date: Thu, 28 Nov 2013 19:31:22 +0100 [thread overview]
Message-ID: <20131128183122.GL25312@twin.jikos.cz> (raw)
In-Reply-To: <1384621747-25441-1-git-send-email-kreijack@inwind.it>
On Sat, Nov 16, 2013 at 06:09:00PM +0100, Goffredo Baroncelli wrote:
> the following patches implement the recursively snapshotting and
> deleting of a subvolume.
Nice feature, but can we try to make the snapshot creation atomic? This
would need support from kernel of course.
I'm worried about the outcome from the users' perspective, the
consistency of the whole subvolume subtree. As you've implemented it,
there are several operations involved like traversing the subvolume
list, replacing the empty-subvols with the real ones, taking the
snapshots. The assumptions about existing source subvolumes may change
in the meantime: renamed or deleted.
The recursive deletion is safer form this point, I'll look at the
patches closer. Deleting the whole directory subtree with randomly
scattered subvolumes is not easy atm, I'm using wrappers around find and
maxdepth/mindepth to look for subvols and issue delete until it's done.
david
next prev parent reply other threads:[~2013-11-28 18:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-16 17:09 [PATCH] BTRFS-PROG: recursively subvolume snapshot and delete Goffredo Baroncelli
2013-11-16 17:09 ` [PATCH 1/7] Recursive btrfs sub snapshot/delete: create get_root_info() function Goffredo Baroncelli
2013-11-16 17:09 ` [PATCH 2/7] recursive btrfs sub snapshot/delete: create pathjoin() function Goffredo Baroncelli
2013-11-16 17:09 ` [PATCH 3/7] recursive btrfs snapshot/delete: create traverse_list_subvol_rec() Goffredo Baroncelli
2013-11-16 17:09 ` [PATCH 4/7] recursive btrfs subvol delete Goffredo Baroncelli
2013-11-16 17:09 ` [PATCH 5/7] recursively btrfs subvolume snapshot Goffredo Baroncelli
2013-11-16 17:09 ` [PATCH 6/7] btrfs subvolume snapshot -R: update man page Goffredo Baroncelli
2013-11-16 17:09 ` [PATCH 7/7] Document the -R switch for the "btrfs subvolume delete" command Goffredo Baroncelli
2013-11-25 21:23 ` [PATCH] BTRFS-PROG: recursively subvolume snapshot and delete Goffredo Baroncelli
2013-11-26 15:12 ` Konstantinos Skarlatos
2013-11-26 17:44 ` Goffredo Baroncelli
2013-11-27 9:15 ` Konstantinos Skarlatos
2013-11-27 17:04 ` Goffredo Baroncelli
2013-11-28 18:31 ` David Sterba [this message]
2013-11-28 19:23 ` Goffredo Baroncelli
2013-11-29 18:07 ` David Sterba
2013-11-29 19:09 ` Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128183122.GL25312@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=kreijack@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).