From: Chris Mason <clm@fb.com>
To: Liu Bo <bo.li.liu@oracle.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: avoid building inode cache repeatly
Date: Mon, 9 Dec 2013 09:20:05 -0500 [thread overview]
Message-ID: <20131209142005.20371.31891@ret.masoncoding.com> (raw)
In-Reply-To: <1386581671-4639-1-git-send-email-bo.li.liu@oracle.com>
Quoting Liu Bo (2013-12-09 04:34:31)
> Inode cache is similar to free space cache and in fact shares the same
> code, however, we don't load inode cache unless we're about to allocate
> inode id, then there is a case where we only commit the transaction during
> other operations, such as snapshot creation, we now update fs roots' generation
> to the new transaction id, after that when we want to load the inode cache,
> we'll find that it's not valid thanks to the mismatch of generation, and we
> have to push btrfs-ino-cache thread to build inode cache from disk, and
> this operation is sometimes time-costing.
>
> So to fix the above, we load inode cache into memory during reading fs root.
Thanks Liu. Have you tested this with orphan replay? I'd like to make
sure the new ordering of starting caching isn't causing problems with
finding and processing the orphan items.
-chris
next prev parent reply other threads:[~2013-12-09 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 9:34 [PATCH] Btrfs: avoid building inode cache repeatly Liu Bo
2013-12-09 14:20 ` Chris Mason [this message]
2013-12-10 8:51 ` Liu Bo
2013-12-10 14:17 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209142005.20371.31891@ret.masoncoding.com \
--to=clm@fb.com \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).