From: Christoph Hellwig <hch@infradead.org>
To: Andreas Gruenbacher <andreas.gruenbacher@linbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-mtd@lists.infradead.org, Mark Fasheh <mfasheh@suse.com>,
Joel Becker <jlbec@evilplan.org>,
reiserfs-devel@vger.kernel.org, xfs@oss.sgi.com,
jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nfs@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 05/18] fs: make posix_acl_chmod more useful
Date: Thu, 12 Dec 2013 13:05:02 -0800 [thread overview]
Message-ID: <20131212210502.GB27686@infradead.org> (raw)
In-Reply-To: <389888733.69110.1386875240679.JavaMail.zimbra@linbit.com>
On Thu, Dec 12, 2013 at 08:07:20PM +0100, Andreas Gruenbacher wrote:
> Christoph,
>
> > +int
> > +posix_acl_chmod(struct inode *inode)
> > +{
> > + struct posix_acl *acl;
> > + int ret = 0;
> > +
> > + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl)
> > + return -EOPNOTSUPP;
>
> Symlinks never have get_acl callbacks, so I would remove the S_ISLNK() check here.
Yeah, will simplify it. Same for the other places where we have both
checks.
next prev parent reply other threads:[~2013-12-12 21:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 10:42 [PATCH 00/18] Consolidate Posix ACL implementation V2 Christoph Hellwig
2013-12-11 10:42 ` [PATCH 01/18] reiserfs: prefix ACL symbols with reiserfs_ Christoph Hellwig
2013-12-11 10:42 ` [PATCH 02/18] fs: add get_acl helper Christoph Hellwig
2013-12-12 19:06 ` Andreas Gruenbacher
2013-12-12 21:04 ` Christoph Hellwig
2013-12-11 10:42 ` [PATCH 03/18] fs: add a set_acl inode operation Christoph Hellwig
2013-12-11 10:42 ` [PATCH 04/18] fs: add generic xattr_acl handlers Christoph Hellwig
2013-12-12 19:07 ` Andreas Gruenbacher
2013-12-11 10:42 ` [PATCH 05/18] fs: make posix_acl_chmod more useful Christoph Hellwig
2013-12-12 19:07 ` Andreas Gruenbacher
2013-12-12 21:05 ` Christoph Hellwig [this message]
2013-12-11 10:42 ` [PATCH 06/18] fs: make posix_acl_create " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 07/18] btrfs: use generic posix ACL infrastructure Christoph Hellwig
2013-12-11 10:42 ` [PATCH 08/18] ext2/3/4: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 09/18] f2fs: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 10/18] hfsplus: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 11/18] jffs2: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 12/18] ocfs2: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 13/18] reiserfs: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 14/18] xfs: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 15/18] jfs: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 16/18] gfs2: " Christoph Hellwig
2013-12-11 10:52 ` [Cluster-devel] " Steven Whitehouse
2013-12-12 19:08 ` Andreas Gruenbacher
2013-12-12 21:05 ` Christoph Hellwig
2013-12-11 10:43 ` [PATCH 17/18] nfs: use generic posix ACL infrastructure for v3 Posix ACLs Christoph Hellwig
2013-12-11 10:43 ` [PATCH 18/18] fs: remove generic_acl Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2013-12-01 11:59 [PATCH 00/18] Consolidate Posix ACL implementation Christoph Hellwig
2013-12-01 11:59 ` [PATCH 05/18] fs: make posix_acl_chmod more useful Christoph Hellwig
2013-12-02 21:09 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212210502.GB27686@infradead.org \
--to=hch@infradead.org \
--cc=andreas.gruenbacher@linbit.com \
--cc=cluster-devel@redhat.com \
--cc=jack@suse.cz \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlbec@evilplan.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).