From: Liu Bo <bo.li.liu@oracle.com>
To: Alex Lyakas <alex.btrfs@zadarastorage.com>
Cc: Jan Schmidt <list.btrfs@jan-o-sch.net>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v7 04/13] Btrfs: disable qgroups accounting when quata_enable is 0
Date: Fri, 13 Dec 2013 14:04:21 +0800 [thread overview]
Message-ID: <20131213060420.GB14429@localhost.localdomain> (raw)
In-Reply-To: <20131213054256.GA14429@localhost.localdomain>
On Fri, Dec 13, 2013 at 01:42:57PM +0800, Liu Bo wrote:
> On Tue, Dec 03, 2013 at 07:13:48PM +0200, Alex Lyakas wrote:
> > Hi Liu, Jan,
> >
> > What happens to "struct qgroup_update"s sitting in
> > trans->qgroup_ref_list in case the transaction aborts? It seems that
> > they are not freed.
> >
> > For example, if we are in btrfs_commit_transaction() and:
> > - call create_pending_snapshots()
> > - call btrfs_run_delayed_items() and this fails
> > So we go to cleanup_transaction() without calling
> > btrfs_delayed_refs_qgroup_accounting(), which would have been called
> > by btrfs_run_delayed_refs().
> >
> > I receive kmemleak warnings about these thingies not being freed,
> > although on an older kernel. However, looking at Josef's tree, this
> > still seems to be the case.
>
> I think you're right, but I'm sure because I cannot reproduce that somehow,
Sorry, s/'sure'/'not sure'/g
-liubo
next prev parent reply other threads:[~2013-12-13 6:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 4:59 [RFC PATCH v7 00/13] Online(inband) data deduplication Liu Bo
2013-10-14 4:59 ` [PATCH v7 01/13] Btrfs: skip merge part for delayed data refs Liu Bo
2013-10-14 4:59 ` [PATCH v7 02/13] Btrfs: improve the delayed refs process in rm case Liu Bo
2013-10-22 20:58 ` Josef Bacik
2013-10-14 4:59 ` [PATCH v7 03/13] Btrfs: introduce a head ref rbtree Liu Bo
2013-10-14 4:59 ` [PATCH v7 04/13] Btrfs: disable qgroups accounting when quata_enable is 0 Liu Bo
2013-12-03 17:13 ` Alex Lyakas
2013-12-03 18:58 ` Alex Lyakas
2013-12-13 5:42 ` Liu Bo
2013-12-13 6:04 ` Liu Bo [this message]
2013-10-14 4:59 ` [PATCH v7 05/13] Btrfs: introduce dedup tree and relatives Liu Bo
2013-10-14 4:59 ` [PATCH v7 06/13] Btrfs: introduce dedup tree operations Liu Bo
2013-10-14 4:59 ` [PATCH v7 07/13] Btrfs: introduce dedup state Liu Bo
2013-10-14 4:59 ` [PATCH v7 08/13] Btrfs: make ordered extent aware of dedup Liu Bo
2013-10-14 4:59 ` [PATCH v7 09/13] Btrfs: online(inband) data dedup Liu Bo
2013-10-14 4:59 ` [PATCH v7 10/13] Btrfs: skip dedup reference during backref walking Liu Bo
2013-10-14 4:59 ` [PATCH v7 11/13] Btrfs: don't return space for dedup extent Liu Bo
2013-10-14 4:59 ` [PATCH v7 12/13] Btrfs: fix a crash of dedup ref Liu Bo
2013-10-14 4:59 ` [PATCH v7 13/13] Btrfs: add ioctl of dedup control Liu Bo
2013-10-14 4:59 ` [PATCH v3] Btrfs-progs: add dedup subcommand Liu Bo
2013-10-22 18:55 ` [RFC PATCH v7 00/13] Online(inband) data deduplication Aurelien Jarno
2013-10-23 2:26 ` Liu Bo
2013-10-23 2:36 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213060420.GB14429@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=alex.btrfs@zadarastorage.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).