[PATCH] Btrfs: fix a warning when iput a file

linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] Btrfs: fix a warning when iput a file
@ 2013-12-14  7:27 Wang Shilong
  2013-12-14 13:49 ` Liu Bo
  2013-12-14 14:54 ` Filipe David Manana
  0 siblings, 2 replies; 4+ messages in thread
From: Wang Shilong @ 2013-12-14  7:27 UTC (permalink / raw)
  To: linux-btrfs

See the warning below:

[ 1209.102076]  [<ffffffffa04721b9>] remove_extent_mapping+0x69/0x70 [btrfs]
[ 1209.102084]  [<ffffffffa0466b06>] btrfs_evict_inode+0x96/0x4d0 [btrfs]
[ 1209.102089]  [<ffffffff81073010>] ? wake_atomic_t_function+0x40/0x40
[ 1209.102092]  [<ffffffff8118ab2e>] evict+0x9e/0x190
[ 1209.102094]  [<ffffffff8118b313>] iput+0xf3/0x180
[ 1209.102101]  [<ffffffffa0461fd1>] btrfs_run_delayed_iputs+0xb1/0xd0 [btrfs]
[ 1209.102107]  [<ffffffffa045d358>] __btrfs_end_transaction+0x268/0x350 [btrfs]

clear extent bit here to avoid triggering WARN_ON() in remove_extent_mapping()

Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
---
 fs/btrfs/inode.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index e889779..c0f0f9d 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -4515,6 +4515,8 @@ static void evict_inode_truncate_pages(struct inode *inode)
 
 		node = rb_first(&map_tree->map);
 		em = rb_entry(node, struct extent_map, rb_node);
+		clear_bit(EXTENT_FLAG_PINNED, &em->flags);
+		clear_bit(EXTENT_FLAG_LOGGING, &em->flags);
 		remove_extent_mapping(map_tree, em);
 		free_extent_map(em);
 	}
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Btrfs: fix a warning when iput a file
  2013-12-14  7:27 [PATCH] Btrfs: fix a warning when iput a file Wang Shilong
@ 2013-12-14 13:49 ` Liu Bo
       [not found]   ` <CAP9B-QnExXqCPxXZxK2ghjfHvfi-pmy-CtKirJLu-vnGzY=+gg@mail.gmail.com>
  2013-12-14 14:54 ` Filipe David Manana
  1 sibling, 1 reply; 4+ messages in thread
From: Liu Bo @ 2013-12-14 13:49 UTC (permalink / raw)
  To: Wang Shilong; +Cc: linux-btrfs

On Sat, Dec 14, 2013 at 03:27:31PM +0800, Wang Shilong wrote:
> See the warning below:
> 
> [ 1209.102076]  [<ffffffffa04721b9>] remove_extent_mapping+0x69/0x70 [btrfs]
> [ 1209.102084]  [<ffffffffa0466b06>] btrfs_evict_inode+0x96/0x4d0 [btrfs]
> [ 1209.102089]  [<ffffffff81073010>] ? wake_atomic_t_function+0x40/0x40
> [ 1209.102092]  [<ffffffff8118ab2e>] evict+0x9e/0x190
> [ 1209.102094]  [<ffffffff8118b313>] iput+0xf3/0x180
> [ 1209.102101]  [<ffffffffa0461fd1>] btrfs_run_delayed_iputs+0xb1/0xd0 [btrfs]
> [ 1209.102107]  [<ffffffffa045d358>] __btrfs_end_transaction+0x268/0x350 [btrfs]
> 
> clear extent bit here to avoid triggering WARN_ON() in remove_extent_mapping()

Why PINNED and LOGGING isn't unset as usual?

-liubo

> 
> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
> ---
>  fs/btrfs/inode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index e889779..c0f0f9d 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -4515,6 +4515,8 @@ static void evict_inode_truncate_pages(struct inode *inode)
>  
>  		node = rb_first(&map_tree->map);
>  		em = rb_entry(node, struct extent_map, rb_node);
> +		clear_bit(EXTENT_FLAG_PINNED, &em->flags);
> +		clear_bit(EXTENT_FLAG_LOGGING, &em->flags);
>  		remove_extent_mapping(map_tree, em);
>  		free_extent_map(em);
>  	}
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

[parent not found: <CAP9B-QnExXqCPxXZxK2ghjfHvfi-pmy-CtKirJLu-vnGzY=+gg@mail.gmail.com>]

* Fwd: [PATCH] Btrfs: fix a warning when iput a file
       [not found]   ` <CAP9B-QnExXqCPxXZxK2ghjfHvfi-pmy-CtKirJLu-vnGzY=+gg@mail.gmail.com>
@ 2013-12-14 14:50     ` Shilong Wang
  0 siblings, 0 replies; 4+ messages in thread
From: Shilong Wang @ 2013-12-14 14:50 UTC (permalink / raw)
  To: linux-btrfs

CC:linux-btrfs

---------- Forwarded message ----------
From: Shilong Wang <wangshilong1991@gmail.com>
Date: 2013/12/14
Subject: Re: [PATCH] Btrfs: fix a warning when iput a file
To: bo.li.liu@oracle.com


Hello Liu

2013/12/14 Liu Bo <bo.li.liu@oracle.com>:
> On Sat, Dec 14, 2013 at 03:27:31PM +0800, Wang Shilong wrote:
>> See the warning below:
>>
>> [ 1209.102076]  [<ffffffffa04721b9>] remove_extent_mapping+0x69/0x70 [btrfs]
>> [ 1209.102084]  [<ffffffffa0466b06>] btrfs_evict_inode+0x96/0x4d0 [btrfs]
>> [ 1209.102089]  [<ffffffff81073010>] ? wake_atomic_t_function+0x40/0x40
>> [ 1209.102092]  [<ffffffff8118ab2e>] evict+0x9e/0x190
>> [ 1209.102094]  [<ffffffff8118b313>] iput+0xf3/0x180
>> [ 1209.102101]  [<ffffffffa0461fd1>] btrfs_run_delayed_iputs+0xb1/0xd0 [btrfs]
>> [ 1209.102107]  [<ffffffffa045d358>] __btrfs_end_transaction+0x268/0x350 [btrfs]
>>
>> clear extent bit here to avoid triggering WARN_ON() in remove_extent_mapping()
>
> Why PINNED and LOGGING isn't unset as usual?
>

Flippe sent an improved patch regarding evict inode:
https://patchwork.kernel.org/patch/3204281/

In btrfs_invalidatepages(), if we are evicting an inode, we will skip
usual operation that is operated page by page.

Rather than we do it more effectively, that we operate extent_map and
extent_state structure, this will be faster!

So for now code , after calling truncate_inode_pages(), PINNED and
LOGGED won't be unset
as usual(Maybe a better solution is to move remove_extent_mappin after
we clear extent state).

Correct me if i am wrong here.

Thanks,
Wang

> -liubo
>
>>
>> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
>> ---
>>  fs/btrfs/inode.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
>> index e889779..c0f0f9d 100644
>> --- a/fs/btrfs/inode.c
>> +++ b/fs/btrfs/inode.c
>> @@ -4515,6 +4515,8 @@ static void evict_inode_truncate_pages(struct inode *inode)
>>
>>               node = rb_first(&map_tree->map);
>>               em = rb_entry(node, struct extent_map, rb_node);
>> +             clear_bit(EXTENT_FLAG_PINNED, &em->flags);
>> +             clear_bit(EXTENT_FLAG_LOGGING, &em->flags);
>>               remove_extent_mapping(map_tree, em);
>>               free_extent_map(em);
>>       }
>> --
>> 1.8.3.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Btrfs: fix a warning when iput a file
  2013-12-14  7:27 [PATCH] Btrfs: fix a warning when iput a file Wang Shilong
  2013-12-14 13:49 ` Liu Bo
@ 2013-12-14 14:54 ` Filipe David Manana
  1 sibling, 0 replies; 4+ messages in thread
From: Filipe David Manana @ 2013-12-14 14:54 UTC (permalink / raw)
  To: Wang Shilong; +Cc: linux-btrfs@vger.kernel.org

On Sat, Dec 14, 2013 at 7:27 AM, Wang Shilong
<wangsl.fnst@cn.fujitsu.com> wrote:
> See the warning below:
>
> [ 1209.102076]  [<ffffffffa04721b9>] remove_extent_mapping+0x69/0x70 [btrfs]
> [ 1209.102084]  [<ffffffffa0466b06>] btrfs_evict_inode+0x96/0x4d0 [btrfs]
> [ 1209.102089]  [<ffffffff81073010>] ? wake_atomic_t_function+0x40/0x40
> [ 1209.102092]  [<ffffffff8118ab2e>] evict+0x9e/0x190
> [ 1209.102094]  [<ffffffff8118b313>] iput+0xf3/0x180
> [ 1209.102101]  [<ffffffffa0461fd1>] btrfs_run_delayed_iputs+0xb1/0xd0 [btrfs]
> [ 1209.102107]  [<ffffffffa045d358>] __btrfs_end_transaction+0x268/0x350 [btrfs]
>
> clear extent bit here to avoid triggering WARN_ON() in remove_extent_mapping()
>
> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>

Thank you Wang for reporting and fix attempt.
While this removes the warning about the pinned flag, it will cause
another warning later. See the patch I just sent as an alternative:

https://patchwork.kernel.org/patch/3348711/

Do you agree?

Also, can you easily trigger that warning, what are the steps to
trigger it? I haven't found yet a way to trigger it.
And did you got one for the logging flag too?

thanks

> ---
>  fs/btrfs/inode.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index e889779..c0f0f9d 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -4515,6 +4515,8 @@ static void evict_inode_truncate_pages(struct inode *inode)
>
>                 node = rb_first(&map_tree->map);
>                 em = rb_entry(node, struct extent_map, rb_node);
> +               clear_bit(EXTENT_FLAG_PINNED, &em->flags);
> +               clear_bit(EXTENT_FLAG_LOGGING, &em->flags);
>                 remove_extent_mapping(map_tree, em);
>                 free_extent_map(em);
>         }
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-12-14 14:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14  7:27 [PATCH] Btrfs: fix a warning when iput a file Wang Shilong
2013-12-14 13:49 ` Liu Bo
     [not found]   ` <CAP9B-QnExXqCPxXZxK2ghjfHvfi-pmy-CtKirJLu-vnGzY=+gg@mail.gmail.com>
2013-12-14 14:50     ` Fwd: " Shilong Wang
2013-12-14 14:54 ` Filipe David Manana

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).