From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Cleanup the unused btrfs_check_super_valid.
Date: Thu, 19 Dec 2013 13:34:40 +0100 [thread overview]
Message-ID: <20131219123440.GC6498@suse.cz> (raw)
In-Reply-To: <1387336468-28785-1-git-send-email-quwenruo@cn.fujitsu.com>
On Wed, Dec 18, 2013 at 11:14:28AM +0800, Qu Wenruo wrote:
> Since in David's commit 1104a8855, there is nothing really check the
> super block now, the btrfs_check_super_valid function can be removed if
> no one else needs the function.
>
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
> Cc: David Sterba <dsterba@suse.cz>
> ---
> -static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info,
> - int read_only)
> -{
> - /*
> - * Placeholder for checks
The comment should motivate to add more tests, not to remove the
supporting code. Please keep it.
> - */
> - return 0;
> -}
prev parent reply other threads:[~2013-12-19 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 3:14 [PATCH] btrfs: Cleanup the unused btrfs_check_super_valid Qu Wenruo
2013-12-19 12:34 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219123440.GC6498@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).