From: Dan Carpenter <dan.carpenter@oracle.com>
To: fholton@gmail.com
Cc: linux-btrfs@vger.kernel.org
Subject: re: Btrfs: convert printk to btrfs_ and fix BTRFS prefix
Date: Thu, 9 Jan 2014 20:53:14 +0300 [thread overview]
Message-ID: <20140109175314.GA3827@elgon.mountain> (raw)
Hello Frank Holton,
This is a semi-automatic email about new static checker warnings.
The patch f2ee0bf65a1c: "Btrfs: convert printk to btrfs_ and fix
BTRFS prefix" from Dec 20, 2013, leads to the following Smatch
complaint:
fs/btrfs/super.c:298 __btrfs_panic()
error: we previously assumed 'fs_info' could be null (see line 294)
fs/btrfs/super.c
293 errstr = btrfs_decode_error(errno);
294 if (fs_info && (fs_info->mount_opt & BTRFS_MOUNT_PANIC_ON_FATAL_ERROR))
^^^^^^^
Existing check.
295 panic(KERN_CRIT "BTRFS panic (device %s) in %s:%d: %pV (errno=%d %s)\n",
296 s_id, function, line, &vaf, errno, errstr);
297
298 btrfs_crit(fs_info, "panic in %s:%d: %pV (errno=%d %s)",
^^^^^^^
Patch introduces new unchecked dereference inside btrfs_crit().
299 function, line, &vaf, errno, errstr);
300 va_end(args);
regards,
dan carpenter
reply other threads:[~2014-01-09 17:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109175314.GA3827@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=fholton@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox