From: Dave Chinner <david@fromorbit.com>
To: Chris Mason <clm@fb.com>
Cc: Josef Bacik <jbacik@fb.com>,
"sandeen@redhat.com" <sandeen@redhat.com>,
"bpm@sgi.com" <bpm@sgi.com>,
"sandeen@sandeen.net" <sandeen@sandeen.net>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: kill lib/random.c
Date: Mon, 13 Jan 2014 12:56:58 +1100 [thread overview]
Message-ID: <20140113015658.GE3469@dastard> (raw)
In-Reply-To: <1389129641.23310.20.camel@ret.masoncoding.com>
On Tue, Jan 07, 2014 at 09:20:12PM +0000, Chris Mason wrote:
> On Tue, 2014-01-07 at 16:17 -0500, Josef Bacik wrote:
> > On 01/07/2014 03:40 PM, Ben Myers wrote:
> > > On Tue, Jan 07, 2014 at 02:10:15PM -0600, Eric Sandeen wrote:
> > >> On 1/7/14, 2:01 PM, Ben Myers wrote:
> > >>> Hey Gents,
> > >>>
> > >>> On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote:
> > >>>> On 1/6/14, 3:42 PM, Josef Bacik wrote:
> > >>>>> On 01/06/2014 04:32 PM, Eric Sandeen wrote:
> > >>>>>> On 1/6/14, 1:58 PM, Josef Bacik wrote:
> > >>>>>>> I was trying to reproduce something with fsx and I noticed that no matter what
> > >>>>>>> seed I set I was getting the same file. Come to find out we are overloading
> > >>>>>>> random() with our own custom horribleness for some unknown reason. So nuke the
> > >>>>>>> damn thing from orbit and rely on glibc's random(). With this fix the -S option
> > >>>>>>> actually does something with fsx. Thanks,
....
> For now we can just use srandom?
Seems to me like it will solve the problem. Josef?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2014-01-13 1:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 19:58 [PATCH] xfstests: kill lib/random.c Josef Bacik
2014-01-06 21:32 ` Eric Sandeen
2014-01-06 21:42 ` Josef Bacik
2014-01-06 21:46 ` Eric Sandeen
2014-01-07 20:01 ` Ben Myers
2014-01-07 20:10 ` Eric Sandeen
2014-01-07 20:15 ` Eric Sandeen
2014-01-07 20:15 ` Josef Bacik
2014-01-07 20:40 ` Ben Myers
2014-01-07 21:17 ` Josef Bacik
2014-01-07 21:20 ` Chris Mason
2014-01-13 1:56 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113015658.GE3469@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=clm@fb.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).