[PATCH] btrfs-progs: update INSTALL file

[PATCH] btrfs-progs: update INSTALL file

[Anand Jain]

with the changes that has happened since last time it was updated

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 INSTALL |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/INSTALL b/INSTALL
index 8ead607..a86878a 100644
--- a/INSTALL
+++ b/INSTALL
@@ -12,7 +12,8 @@ complete:
 modprobe libcrc32c
 insmod btrfs.ko
 
-The Btrfs utility programs require libuuid to build.  This can be found
+The Btrfs utility programs (btrfs-progs) require libattr zlib libacl
+e2fsprogs libblkid lzo2 to build.  This can be found
 in the e2fsprogs sources, and is usually available as libuuid or
 e2fsprogs-devel from various distros.
 
@@ -49,6 +50,3 @@ btrfsck: do a limited check of the FS extent trees.</li>
 btrfs-debug-tree: print all of the FS metadata in text form.  Example:
 
 	btrfs-debug-tree /dev/sda2 >& big_output_file
-
-
-
-- 
1.7.1

Re: [PATCH] btrfs-progs: update INSTALL file

[David Sterba]

On Wed, Jan 22, 2014 at 02:19:37PM +0800, Anand Jain wrote:
> --- a/INSTALL
> +++ b/INSTALL
> @@ -12,7 +12,8 @@ complete:
>  modprobe libcrc32c
>  insmod btrfs.ko
>  
> -The Btrfs utility programs require libuuid to build.  This can be found
> +The Btrfs utility programs (btrfs-progs) require libattr zlib libacl
> +e2fsprogs libblkid lzo2 to build.  This can be found

The following sentence does not make sense in the context of the
extended list, also I think that the dependencies should be listed one
per-line so it's more clear.

>  in the e2fsprogs sources, and is usually available as libuuid or
>  e2fsprogs-devel from various distros.

The whole file looks very obsolete, mentions kernel module dependencies
as well. Not a priority, but I wouldn't mind trimming the unrelated
information and keep just what's related to userspace, eg. how to build,
run local tests, where to find git sources.

Re: [PATCH] btrfs-progs: update INSTALL file

[Daniel Cegiełka]

2014-01-22 Anand Jain <anand.jain@oracle.com>:
> with the changes that has happened since last time it was updated
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
>  INSTALL |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index 8ead607..a86878a 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -12,7 +12,8 @@ complete:
>  modprobe libcrc32c
>  insmod btrfs.ko
>
> -The Btrfs utility programs require libuuid to build.  This can be found
> +The Btrfs utility programs (btrfs-progs) require libattr zlib libacl
> +e2fsprogs libblkid lzo2 to build.  This can be found
>  in the e2fsprogs sources, and is usually available as libuuid or
>  e2fsprogs-devel from various distros.

Which version of libblkid should we use? From e2fsprogs or from util-linux?

libattr/libacl: these libraries are not necessary - you need it only to convert.

Daniel

Re: [PATCH] btrfs-progs: update INSTALL file

[Darrick J. Wong]

On Mon, Jan 27, 2014 at 10:21:32PM +0100, Daniel Cegiełka wrote:
> 2014-01-22 Anand Jain <anand.jain@oracle.com>:
> > with the changes that has happened since last time it was updated
> >
> > Signed-off-by: Anand Jain <anand.jain@oracle.com>
> > ---
> >  INSTALL |    6 ++----
> >  1 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/INSTALL b/INSTALL
> > index 8ead607..a86878a 100644
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -12,7 +12,8 @@ complete:
> >  modprobe libcrc32c
> >  insmod btrfs.ko
> >
> > -The Btrfs utility programs require libuuid to build.  This can be found
> > +The Btrfs utility programs (btrfs-progs) require libattr zlib libacl
> > +e2fsprogs libblkid lzo2 to build.  This can be found
> >  in the e2fsprogs sources, and is usually available as libuuid or
> >  e2fsprogs-devel from various distros.
> 
> Which version of libblkid should we use? From e2fsprogs or from util-linux?

I think most of the world uses the util-linux version now.  I don't think
there's been much development to the e2fsprogs one in years, aside from
bugfixes.

--D
> 
> libattr/libacl: these libraries are not necessary - you need it only to convert.
> 
> Daniel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] btrfs-progs: update INSTALL file

[Anand Jain]

  Yep. I had the same opinion as well but was hesitant
  to make wide changes unless understand the backaground.
  Now would try to re-write as a whole and review will help.

Thanks, Anand

On 01/28/2014 02:27 AM, David Sterba wrote:
> On Wed, Jan 22, 2014 at 02:19:37PM +0800, Anand Jain wrote:
>> --- a/INSTALL
>> +++ b/INSTALL
>> @@ -12,7 +12,8 @@ complete:
>>   modprobe libcrc32c
>>   insmod btrfs.ko
>>
>> -The Btrfs utility programs require libuuid to build.  This can be found
>> +The Btrfs utility programs (btrfs-progs) require libattr zlib libacl
>> +e2fsprogs libblkid lzo2 to build.  This can be found
>
> The following sentence does not make sense in the context of the
> extended list, also I think that the dependencies should be listed one
> per-line so it's more clear.
>
>>   in the e2fsprogs sources, and is usually available as libuuid or
>>   e2fsprogs-devel from various distros.
>
> The whole file looks very obsolete, mentions kernel module dependencies
> as well. Not a priority, but I wouldn't mind trimming the unrelated
> information and keep just what's related to userspace, eg. how to build,
> run local tests, where to find git sources.
>