linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: linux-btrfs@vger.kernel.org
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3 0/3] __btrfs_drop_extents() BUG_ON reproducer
Date: Fri, 14 Feb 2014 13:46:56 +0100	[thread overview]
Message-ID: <20140214134656.7c1f2544@plati.site> (raw)
In-Reply-To: <1391769341-20688-1-git-send-email-ddiss@suse.de>

Ping, any Btrfsers get a chance to look at this patch series?
I'd like to get it into the QA tree.

On Fri,  7 Feb 2014 11:35:38 +0100, David Disseldorp wrote:

> This patch-set provides a reproducer for hitting the 3.14.0-rc1 BUG_ON()
> at:
>  692 int __btrfs_drop_extents(struct btrfs_trans_handle *trans,
> ...
>  839                 /*
>  840                  *  | ---- range to drop ----- |
>  841                  *      | -------- extent -------- |
>  842                  */
>  843                 if (start <= key.offset && end < extent_end) {
>  844                         BUG_ON(extent_type == BTRFS_FILE_EXTENT_INLINE);
>  845 
>  846                         memcpy(&new_key, &key, sizeof(new_key));
> 
> The first patch adds a small cloner binary which is used by btrfs/035 to
> dispatch BTRFS_IOC_CLONE_RANGE requests.
> 
> This workload resembles that of Samba's vfs_btrfs module, when a Windows
> client restores a file from a shadow-copy (snapshot) using server-side
> copy requests.
> 
> Changes since V2:
> - Remove explicit write error checks
> 
> Changes since V1:
> - Use strtoull instead of atoi
> - Print error conditions in cloner
> - Check for cloner binary before running test
> - Continue test on failure
> - Add cloner to .gitignore
> 
> Feedback appreciated.
> 
> Cheers, David
> 
> 
>  .gitignore          |   1 +
>  configure.ac        |   1 +
>  src/Makefile        |   2 +-
>  src/cloner.c        | 192 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/btrfs/035     |  77 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/btrfs/035.out |   3 +++
>  tests/btrfs/group   |   1 +
>  7 files changed, 276 insertions(+), 1 deletion(-)

  parent reply	other threads:[~2014-02-14 12:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 10:35 [PATCH v3 0/3] __btrfs_drop_extents() BUG_ON reproducer David Disseldorp
2014-02-07 10:35 ` [PATCH v3 1/3] btrfs: add small program for clone testing David Disseldorp
2014-02-07 10:35 ` [PATCH v3 2/3] src/cloner: use btrfs/ioctl.h header if present David Disseldorp
2014-02-07 10:35 ` [PATCH v3 3/3] btrfs/035: add new clone overwrite regression test David Disseldorp
2014-02-14 12:46 ` David Disseldorp [this message]
2014-02-14 13:39   ` [PATCH v3 0/3] __btrfs_drop_extents() BUG_ON reproducer Filipe David Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140214134656.7c1f2544@plati.site \
    --to=ddiss@suse.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).