From: David Sterba <dsterba@suse.cz>
To: Guangyu Sun <guangyu.sun@oracle.com>
Cc: linux-btrfs@vger.kernel.org, koen.de.wit@oracle.com
Subject: Re: [PATCH v2] Btrfs: return EPERM when deleting a default subvolume
Date: Wed, 12 Mar 2014 13:33:49 +0100 [thread overview]
Message-ID: <20140312123349.GY7004@suse.cz> (raw)
In-Reply-To: <1394562258-17024-1-git-send-email-guangyu.sun@oracle.com>
On Tue, Mar 11, 2014 at 11:24:18AM -0700, Guangyu Sun wrote:
> The error message is confusing:
>
> # btrfs sub delete /mnt/mysub/
> Delete subvolume '/mnt/mysub'
> ERROR: cannot delete '/mnt/mysub' - Directory not empty
>
> The error message does not make sense to me: It's not about deleting a
> directory but it's a subvolume, and it doesn't matter if the subvolume is
> empty or not.
>
> Maybe EPERM or is more appropriate in this case, combined with an explanatory
> kernel log message. (e.g. "subvolume with ID 123 cannot be deleted because
> it is configured as default subvolume.")
>
> Reported-by: Koen De Wit <koen.de.wit@oracle.com>
> Signed-off-by: Guangyu Sun <guangyu.sun@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
prev parent reply other threads:[~2014-03-12 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 18:24 [PATCH v2] Btrfs: return EPERM when deleting a default subvolume Guangyu Sun
2014-03-12 7:58 ` Duncan
2014-03-12 12:33 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312123349.GY7004@suse.cz \
--to=dsterba@suse.cz \
--cc=guangyu.sun@oracle.com \
--cc=koen.de.wit@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox