public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Rakesh Pandit <rakesh@tuxera.com>
To: <linux-btrfs@vger.kernel.org>
Subject: [PATCH] Btrfs-progs: mkfs: let user known when forcing mixed metadata/data groups
Date: Wed, 12 Mar 2014 15:43:24 +0200	[thread overview]
Message-ID: <20140312134322.GA28005@localhost.localdomain> (raw)

While formatting multiple devics (and user doesn't specify -M) if one
of them has block count or size less then 1 GiB, mkfs doesn't tell
user, on which one mixed metadata/data was forced. This patch updates
message to print device name.

Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
---
 mkfs.c  | 3 ++-
 utils.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/mkfs.c b/mkfs.c
index 2dc90c2..621c869 100644
--- a/mkfs.c
+++ b/mkfs.c
@@ -1372,7 +1372,8 @@ int main(int ac, char **av)
 	ssd = is_ssd(file);
 
 	if (is_vol_small(file)) {
-		printf("SMALL VOLUME: forcing mixed metadata/data groups\n");
+		printf("SMALL VOLUME %s: forcing mixed metadata/data groups\n",
+			file);
 		mixed = 1;
 	}
 
diff --git a/utils.c b/utils.c
index 37ec6e5..00dde0f 100644
--- a/utils.c
+++ b/utils.c
@@ -597,7 +597,7 @@ int btrfs_prepare_device(int fd, char *file, int zero_end, u64 *block_count_ret,
 	zero_end = 1;
 
 	if (block_count < 1024 * 1024 * 1024 && !(*mixed)) {
-		printf("SMALL VOLUME: forcing mixed metadata/data groups\n");
+		printf("SMALL VOLUME %s: forcing mixed metadata/data groups\n", file);
 		*mixed = 1;
 	}
 
-- 
1.8.5.3


             reply	other threads:[~2014-03-12 13:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-12 13:43 Rakesh Pandit [this message]
2014-03-12 16:36 ` [PATCH] Btrfs-progs: mkfs: let user known when forcing mixed metadata/data groups David Sterba
2014-03-12 16:59   ` Rakesh Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140312134322.GA28005@localhost.localdomain \
    --to=rakesh@tuxera.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox