From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:25747 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbaDDVMl (ORCPT ); Fri, 4 Apr 2014 17:12:41 -0400 Date: Sat, 5 Apr 2014 08:12:25 +1100 From: Dave Chinner To: Filipe David Manana Cc: "xfs@oss.sgi.com" , "linux-btrfs@vger.kernel.org" , linux-ext4@vger.kernel.org, lczerner@redhat.com Subject: Re: [ANNOUNCE] xfstests: updated to cf1ed54 Message-ID: <20140404211224.GX17603@dastard> References: <20140404090357.GW17603@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Fri, Apr 04, 2014 at 02:07:16PM +0100, Filipe David Manana wrote: > On Fri, Apr 4, 2014 at 10:03 AM, Dave Chinner wrote: > > Hi folks, > > > > The xfstests repository at git://oss.sgi.com/xfs/cmds/xfstests has > > just been updated. Patches often get missed, so please check if your > > outstanding patches were in this update. If they have not been in > > this update, please resubmit them to xfs@oss.sgi.com so they can be > > picked up in the next update. > > > > The new head of the master branch is commit: > > > > cf1ed54 check: fix RESULT_BASE typo in check script > > > > The major new functionality worth mentioning in this update is the > > new config file format from Lukas. The existing format config files > > should continue to work without change, but the new format is much > > richer and allows specification of multiple different configurations > > to run test under. Hence testing multiple mount an dmkfs > > configurations becomes as simple as iterating the configurations > > in the config file. > > Hi, > > I might be missing something, but after checking out these changes, I > am no longer able to run btrfs tests. Example: > > $ ./check btrfs/041 > common/config: Error: $SCRATCH_DEV should be unset when $SCRATCH_DEV_POOL is set > Passed all 0 tests > > $ cat local.config > export TEST_DEV=/dev/sdb > export TEST_DIR=/home/fdmanana/btrfs-tests/dev > export SCRATCH_MNT="/home/fdmanana/btrfs-tests/scratch_1" > export SCRATCH_DEV_POOL="/dev/sdc /dev/sdd" OK, that'll be a bug in the new config file parsing code. Lukas, can you have a look at this? Cheers, Dave. -- Dave Chinner david@fromorbit.com