From: Al Viro <viro@ZenIV.linux.org.uk>
To: Chris Mason <clm@fb.com>
Cc: Qu Wenruo <quwenruo@cn.fujitsu.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [RFC] odd thing in btrfs_file_aio_write()
Date: Mon, 14 Apr 2014 01:26:25 +0100 [thread overview]
Message-ID: <20140414002625.GQ18016@ZenIV.linux.org.uk> (raw)
end_pos = round_up(pos + iov->iov_len, root->sectorsize);
added in commit 3ac0d7b96a268a98bd474cab8bce3a9f125aaccf
Author: Qu Wenruo <quwenruo@cn.fujitsu.com>
Date: Thu Mar 27 02:51:58 2014 +0000
btrfs: Change the expanding write sequence to fix snapshot related bug.
doesn't look right - after all, just split the first iovec in the array
and end_pos will go down. Do we want pos + count instead of
pos + iov->iov_len there?
next reply other threads:[~2014-04-14 0:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 0:26 Al Viro [this message]
2014-04-14 2:35 ` [RFC] odd thing in btrfs_file_aio_write() Qu Wenruo
2014-04-14 2:48 ` Al Viro
2014-04-14 3:36 ` Qu Wenruo
2014-04-14 5:08 ` Al Viro
2014-04-14 7:21 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414002625.GQ18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).