From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:52176 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbaDPA3k (ORCPT ); Tue, 15 Apr 2014 20:29:40 -0400 Date: Wed, 16 Apr 2014 10:29:25 +1000 From: Dave Chinner To: Filipe David Borba Manana Cc: xfs@oss.sgi.com, jbacik@fb.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH] xfstests: btrfs, add test for btrfs properties Message-ID: <20140416002925.GW15995@dastard> References: <1397591424-25439-1-git-send-email-fdmanana@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1397591424-25439-1-git-send-email-fdmanana@gmail.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Tue, Apr 15, 2014 at 08:50:24PM +0100, Filipe David Borba Manana wrote: > This test case verifies the btrfs properties feature, a new feature > introduced in the linux kernel version 3.14. > > Signed-off-by: Filipe David Borba Manana ... > --- > common/rc | 9 +++ > tests/btrfs/048 | 220 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/048.out | 78 +++++++++++++++++++ > tests/btrfs/group | 1 + > 4 files changed, 308 insertions(+) > create mode 100755 tests/btrfs/048 > create mode 100644 tests/btrfs/048.out > > diff --git a/common/rc b/common/rc > index acf419b..d4ba74f 100644 > --- a/common/rc > +++ b/common/rc > @@ -2262,6 +2262,15 @@ _run_btrfs_util_prog() > run_check $BTRFS_UTIL_PROG $* > } > > +_require_btrfs_properties() > +{ > + $BTRFS_UTIL_PROG | grep 'btrfs property ' > /dev/null 2>&1 > + if [ $? -ne 0 ] > + then > + _notrun "Missing btrfs-progs with properties support, skipped this test" > + fi if [ ... ]; then .... > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here="`pwd`" > +tmp=/tmp/$$ > + > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +send_files_dir=$TEST_DIR/btrfs-test-$seq You should define this after including the common/* files. Cheers, Dave. -- Dave Chinner david@fromorbit.com