From: Xavier Bassery <xavier@bartica.org>
To: linux-btrfs@vger.kernel.org
Cc: Hugo Mills <hugo@carfax.org.uk>, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH] btrfs-progs: read global reserve size from space infos
Date: Tue, 22 Apr 2014 17:12:34 +0200 [thread overview]
Message-ID: <20140422171234.51a9fffb@renoir.lan> (raw)
In-Reply-To: <20140422140900.GA30423@carfax.org.uk>
On Tue, 22 Apr 2014 15:09:00 +0100
Hugo Mills <hugo@carfax.org.uk> wrote:
> On Tue, Apr 22, 2014 at 03:20:00PM +0200, David Sterba wrote:
> > Kernels 3.15 > export the global block reserve as a space info
> > presented by 'btrfs fi df' but would display 'unknown' instead of
> > some meaningful string.
> >
> > Signed-off-by: David Sterba <dsterba@suse.cz>
> > ---
> >
> > Global_rsv or GlobalRsv or Globalrsv or something else?
>
> Personally, I'd probably go for the camel case GlobalRsv, or
> possibly GlbReserve. (Assuming that it's going to be only a single
> token without whitespace to make parsing easier).
I second the camel case (if whitespace is to be avoided) and if I may
put my two cents in, what about GlobalReserve?
As pointed by Hugo, this has the same length as Data+Metadata.
Xavier
next prev parent reply other threads:[~2014-04-22 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 13:20 [PATCH] btrfs-progs: read global reserve size from space infos David Sterba
2014-04-22 14:09 ` Hugo Mills
2014-04-22 15:12 ` Xavier Bassery [this message]
2014-04-23 13:30 ` David Sterba
2014-04-23 14:09 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422171234.51a9fffb@renoir.lan \
--to=xavier@bartica.org \
--cc=dsterba@suse.cz \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).