Re: [PATCH 1/2] Btrfs-progs: set string end sing '\0' for property

[Liu Bo <bo.li.liu@oracle.com>]

On Fri, Apr 25, 2014 at 11:07:49AM +0100, Filipe David Manana wrote:
> On Fri, Apr 25, 2014 at 7:29 AM, Liu Bo <bo.li.liu@oracle.com> wrote:
> > Set string "xattr_name" 's end with '\0' so that it won't be
> > violated in memory.
> >
> > With this fix, xfstest/btrfs/048 can pass on my box.
> >
> > Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
> > ---
> >  props.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/props.c b/props.c
> > index 4d0aeea..53223a3 100644
> > --- a/props.c
> > +++ b/props.c
> > @@ -135,6 +135,7 @@ static int prop_compression(enum prop_object_type type,
> >         }
> >         memcpy(xattr_name, XATTR_BTRFS_PREFIX, XATTR_BTRFS_PREFIX_LEN);
> >         memcpy(xattr_name + XATTR_BTRFS_PREFIX_LEN, name, strlen(name));
> > +       xattr_name[XATTR_BTRFS_PREFIX_LEN + strlen(name)] = '\0';
> 
> Buffer overrun. You need to sum + 1 to the malloc argument above.

Oops, I made that mistake.

thanks,
-liubo