Re: [PATCH 1/1] btrfs-progs: fix build, manpage compression command

[Christian Hesse <mail@eworm.de>]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

David Sterba <dsterba@suse.cz> on Tue, 2014/06/03 11:14:
> On Tue, Jun 03, 2014 at 08:09:25AM +0200, Christian Hesse wrote:
> > man pages for btrfs-progs are compressed by gzip by default. In Makefile
> > the variable GZIP is use, this evaluates to 'gzip gzip' on my system.
> > >From man gzip:
> > 
> > > The environment variable GZIP can hold a set of default options for
> > > gzip. These options are interpreted first and can be overwritten by
> > > explicit command line parameters.
> > 
> > So using any other variable name fixes this.
> 
> Thanks, I can see that you've fixed this bug for the second time.  The
> GZIP variable name got reverted during the asciidoc update and slipped
> through, sorry for that.

No problem, it is not a big deal.

> > --- a/Documentation/Makefile
> > +++ b/Documentation/Makefile
> > @@ -56,7 +56,7 @@ ifneq ($(findstring $(MAKEFLAGS),s),s)
> >  ifndef V
> >  	QUIET_ASCIIDOC	= @echo '   ' ASCIIDOC $@;
> >  	QUIET_XMLTO	= @echo '   ' XMLTO $@;
> > -	QUIET_GZIP	= @echo '   ' GZIP $@;
> > +	QUIET_GZIP	= @echo '   ' GZIPCMD $@;
> 
> JFYI, I've removed this change so the output stays the same.
> 
> I've assembled a branch containing doc-only fixes, including this one,
> and asked Chris do do a 3.14.3 release.

Thanks.
Though I would be fine if this just goes into the next regular release.
-- 
Schoene Gruesse
Chris
                         O< ascii ribbon campaign
                   stop html mail - www.asciiribbon.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]