From: David Sterba <dsterba@suse.cz>
To: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Cc: Adam Buchbinder <abuchbinder@google.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Fix undefined behavior in radix-tree.c.
Date: Thu, 19 Jun 2014 15:28:45 +0200 [thread overview]
Message-ID: <20140619132845.GC1903@suse.cz> (raw)
In-Reply-To: <53A2389F.6050404@jp.fujitsu.com>
On Thu, Jun 19, 2014 at 10:10:55AM +0900, Satoru Takeuchi wrote:
> It's fixed at 430d275a399.
>
> ===============================================================================
> commit 430d275a399175c7c0673459738979287ec1fd22
> Author: Peter Lund <firefly@vax64.dk>
> Date: Tue Oct 16 23:29:35 2007 -0700
>
> avoid negative (and full-width) shifts in radix-tree.c
> ...
> ===============================================================================
>
> Adam, David, how about import this patch from kernel, rather than
> writing btrfs-progs's own patch?
Well, I think there's non-trivial time spent by Adam on the patch so I'd
rather keep the credit, even if a patch that backports the fix from
kernel would look cleaner in git log. Such things happen, sometimes it
makes sense to replace patches or do changes inline.
The progs development is moving forward quickly, a clean patch history
is most useful when there is a separate stable branch that receives
bugfixes as it helps the backporters to identify complete fixes. Not the
case for progs right now.
> I consider It's better to regularly sync such utility code with
> the newest kernel code for the long term...
Yes. The radix- or rb- tree code does not change often though, we can do
a sync now and be fine for some time.
next prev parent reply other threads:[~2014-06-19 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 21:18 [PATCH] Fix undefined behavior in radix-tree.c Adam Buchbinder
2014-06-18 6:20 ` Satoru Takeuchi
2014-06-18 14:43 ` David Sterba
2014-06-19 1:10 ` Satoru Takeuchi
2014-06-19 13:28 ` David Sterba [this message]
2014-06-19 23:51 ` Satoru Takeuchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619132845.GC1903@suse.cz \
--to=dsterba@suse.cz \
--cc=abuchbinder@google.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=takeuchi_satoru@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).