From: Zach Brown <zab@zabbo.net>
To: Mark Fasheh <mfasheh@suse.de>
Cc: Dave Chinner <david@fromorbit.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot
Date: Thu, 10 Jul 2014 11:32:28 -0700 [thread overview]
Message-ID: <20140710183228.GD17201@lenny.home.zabbo.net> (raw)
In-Reply-To: <20140710173614.GB5484@wotan.suse.de>
On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote:
> On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave Chinner wrote:
> > On Wed, Jul 09, 2014 at 03:41:50PM -0700, Mark Fasheh wrote:
> > > +
> > > +# Enable qgroups now that we have our filesystem prepared. This
> > > +# will kick off a scan which we will have to wait for below.
> > > +$BTRFS_UTIL_PROG qu en $SCRATCH_MNT
> > > +sleep 30
> >
> > That seems rather arbitrary. The sleeps you are adding add well over
> > a minute to the runtime, and a quota scan of a filesystem with 200
> > files should be almost instantenous.
>
> Yeah I'll bring that back down to 5 seconds?
How long does it usually take?
What interfaces would be needed for this to work precisely so we don't
have to play this game ever again?
- z
next prev parent reply other threads:[~2014-07-10 18:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 22:41 [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot Mark Fasheh
2014-07-10 0:43 ` Dave Chinner
2014-07-10 17:36 ` Mark Fasheh
2014-07-10 18:32 ` Zach Brown [this message]
2014-07-10 19:00 ` Mark Fasheh
2014-07-10 19:05 ` Zach Brown
2014-07-10 19:24 ` Mark Fasheh
2014-07-10 21:31 ` Duncan
2014-07-22 18:10 ` David Sterba
2014-07-22 19:05 ` David Sterba
2014-07-23 12:30 ` David Sterba
2014-07-23 13:25 ` Josef Bacik
2014-07-10 21:10 ` Dave Chinner
2014-07-22 18:01 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710183228.GD17201@lenny.home.zabbo.net \
--to=zab@zabbo.net \
--cc=clm@fb.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mfasheh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).