From: Zach Brown <zab@zabbo.net>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Chris Mason <clm@fb.com>,
Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/1] Btrfs: fix sparse warning
Date: Wed, 16 Jul 2014 10:20:21 -0700 [thread overview]
Message-ID: <20140716172021.GA10833@lenny.home.zabbo.net> (raw)
In-Reply-To: <1405451837-8235-1-git-send-email-fabf@skynet.be>
On Tue, Jul 15, 2014 at 09:17:17PM +0200, Fabian Frederick wrote:
> Fix the following sparse warning:
> fs/btrfs/send.c:518:51: warning: incorrect type in argument 2 (different address spaces)
> fs/btrfs/send.c:518:51: expected char const [noderef] <asn:1>*<noident>
> fs/btrfs/send.c:518:51: got char *
>
> We can safely use (const char __user *) with set_fs(KERNEL_DS)
Yeah, that cast is correct.
Reviewed-by: Zach Brown <zab@zabbo.net>
> @@ -515,7 +515,8 @@ static int write_buf(struct file *filp, const void *buf, u32 len, loff_t *off)
Though this probably wants to be rewritten in terms of kernel_write().
That'd give an opportunity to get rid of the sctx->send_off and have it
use f_pos in the filp.
- z
next prev parent reply other threads:[~2014-07-16 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 19:17 [PATCH 1/1] Btrfs: fix sparse warning Fabian Frederick
2014-07-16 17:20 ` Zach Brown [this message]
2014-07-17 18:37 ` Fabian Frederick
2014-07-17 19:01 ` Zach Brown
2014-08-02 12:24 ` Fabian Frederick
2014-08-04 18:31 ` Zach Brown
2014-08-05 9:20 ` Fabian Frederick
2014-08-05 21:32 ` Zach Brown
2014-08-18 16:53 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716172021.GA10833@lenny.home.zabbo.net \
--to=zab@zabbo.net \
--cc=clm@fb.com \
--cc=fabf@skynet.be \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).