From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/4] btrfs-progs: Fix wrong indent in btrfs-progs.
Date: Tue, 29 Jul 2014 14:02:46 +0200 [thread overview]
Message-ID: <20140729120246.GN1553@twin.jikos.cz> (raw)
In-Reply-To: <1404961513-14614-3-git-send-email-quwenruo@cn.fujitsu.com>
On Thu, Jul 10, 2014 at 11:05:12AM +0800, Qu Wenruo wrote:
> When editing cmds-filesystem.c, I found cmd_filesystem_df() uses 7
> spaces as indent instead of 1 tab (or 8 spaces). which makes indent
> quite embarrassing.
> Such problem is especillay hard to detect when reviewing patches,
> since the leading '+' makes a tab only 7 spaces long, makeing 7 spaces
> look the same with a tab.
>
> This patch fixes all the 7 spaces indent.
The whitespace changes cause patch conflicts and I'm inclined not to add
them or postpone after the patch queue is relatively calm.
next prev parent reply other threads:[~2014-07-29 12:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 3:05 [PATCH RESEND 1/4] btrfs-progs: Check fstype in find_mount_root() Qu Wenruo
2014-07-10 3:05 ` [PATCH 2/4] btrfs-progs: Integrate error message output into find_mount_root() Qu Wenruo
2014-07-10 7:33 ` Satoru Takeuchi
2014-07-10 8:10 ` Miao Xie
2014-07-10 8:26 ` Qu Wenruo
2014-07-10 23:24 ` Satoru Takeuchi
2014-07-10 3:05 ` [PATCH 3/4] btrfs-progs: Fix wrong indent in btrfs-progs Qu Wenruo
2014-07-10 7:34 ` Satoru Takeuchi
2014-07-29 12:02 ` David Sterba [this message]
2014-07-10 3:05 ` [PATCH v2 RESEND 4/4] btrfs-progs: Add mount point output for 'btrfs fi df' Qu Wenruo
2014-07-10 12:35 ` [PATCH RESEND 1/4] btrfs-progs: Check fstype in find_mount_root() Martin Steigerwald
2014-07-22 19:15 ` David Sterba
2014-07-23 1:23 ` Qu Wenruo
-- strict thread matches above, loose matches on Subject: below --
2014-07-23 5:47 [PATCH 1/4] btrfs-progs: Remove fprintf() " Qu Wenruo
2014-07-23 5:47 ` [PATCH 3/4] btrfs-progs: Fix wrong indent in btrfs-progs Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729120246.GN1553@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).