From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-porgs: fix xfstest btrfs/023 random failure
Date: Tue, 29 Jul 2014 14:57:23 +0200 [thread overview]
Message-ID: <20140729125723.GR1553@twin.jikos.cz> (raw)
In-Reply-To: <1405589304-7174-1-git-send-email-anand.jain@oracle.com>
On Thu, Jul 17, 2014 at 05:28:24PM +0800, Anand Jain wrote:
> xfstest btrfs/023 which does the following tests
>
> create_group_profile "raid0"
> check_group_profile "RAID0"
>
> create_group_profile "raid1"
> check_group_profile "RAID1"
>
> create_group_profile "raid10"
> check_group_profile "RAID10"
>
> create_group_profile "raid5"
> check_group_profile "RAID5"
>
> create_group_profile "raid6"
> check_group_profile "RAID6"
>
> fails randomly with the error as below
>
> ERROR: device scan failed '/dev/sde' - Invalid argument
>
> since failure is at random group profile it indicates to me that
> btrfs kernel did not see the newly created btrfs on the device
>
> To note: I have the following patch on the kernel which
> is not yet integrated, but its not related to this bug.
>
> btrfs: RFC: code optimize use btrfs_get_bdev_and_sb() at btrfs_scan_one_device
I guess the error was caused by this patch, and the fsync just made the
race window smaller. If you still think the fsync is useful, please
update the changelog.
next prev parent reply other threads:[~2014-07-29 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 9:28 [PATCH] btrfs-porgs: fix xfstest btrfs/023 random failure Anand Jain
2014-07-29 12:57 ` David Sterba [this message]
2014-07-31 7:07 ` Anand Jain
2014-07-31 12:01 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729125723.GR1553@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).