From: Mark Fasheh <mfasheh@suse.de>
To: Austin S Hemmelgarn <ahferroin7@gmail.com>
Cc: dsterba@suse.cz, Timofey Titovets <nefelim4ag@gmail.com>,
linux-btrfs@vger.kernel.org
Subject: Re: Btrfs offline deduplication
Date: Fri, 1 Aug 2014 11:55:59 -0700 [thread overview]
Message-ID: <20140801185559.GG2203@wotan.suse.de> (raw)
In-Reply-To: <53DBA128.8060605@gmail.com>
On Fri, Aug 01, 2014 at 10:16:08AM -0400, Austin S Hemmelgarn wrote:
> On 2014-08-01 09:23, David Sterba wrote:
> > On Fri, Aug 01, 2014 at 06:17:44AM -0400, Austin S Hemmelgarn wrote:
> >> I do think however that having the option of a background thread doing
> >> deduplication asynchronously is a good idea, but then you would have to
> >> have some way to trigger it on individual files/trees, and triggering on
> >> writes like the autodefrag thread does doesn't make much sense. Having
> >> some userspace program to tell it to run on a given set of files would
> >> probably be the best approach for a trigger. I don't remember if this
> >> kind of thing was also included in the online deduplication patches that
> >> got posted a while back or not.
> >
> > IIRC the proposed implementation only merged new writes with existing
> > data.
> >
> > For the out-of-band ("off-line") dedup there's bedup
> > (https://github.com/g2p/bedup) or Mark's duperemove tool
> > (https://github.com/markfasheh/duperemove) that work on a set of files.
> >
> Something kernel-side to do the work asynchronously would be nice,
> especially if it could leverage the check-sums that BTRFS already stores
> for the blocks. Having a userspace interface for offline deduplication
> similar to that for scrub operations would even better.
Why does this have to be kernel side? There's userspace software already to
dedupe that can be run on a regular basis. Exporting checksums is a
differnet story (you can do that via ioctl) but running the dedupe software
itself inside the kernel is exactly what we want to avoid by having the
dedupe ioctl in the first place.
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2014-08-01 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 23:54 Btrfs offline deduplication Timofey Titovets
2014-08-01 10:17 ` Austin S Hemmelgarn
2014-08-01 13:23 ` David Sterba
2014-08-01 14:16 ` Austin S Hemmelgarn
2014-08-01 18:55 ` Mark Fasheh [this message]
2014-08-01 19:18 ` Austin S Hemmelgarn
2014-08-01 20:18 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801185559.GG2203@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=ahferroin7@gmail.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nefelim4ag@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox