From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/8] btrfs: replace seed device followed by unmount causes kernel WARNING
Date: Tue, 19 Aug 2014 17:44:28 +0200 [thread overview]
Message-ID: <20140819154428.GA1553@twin.jikos.cz> (raw)
In-Reply-To: <1407911066-5363-2-git-send-email-anand.jain@oracle.com>
On Wed, Aug 13, 2014 at 02:24:20PM +0800, Anand Jain wrote:
> reproducer:
> mount /dev/sdb /btrfs
> btrfs dev add /dev/sdc /btrfs
> btrfs rep start -B /dev/sdb /dev/sdd /btrfs
> umount /btrfs
>
> WARNING: CPU: 0 PID: 12661 at fs/btrfs/volumes.c:891 __btrfs_close_devices+0x1b0/0x200 [btrfs]()
> ::
>
> __btrfs_close_devices()
> ::
> WARN_ON(fs_devices->open_devices);
>
> After the seed device has been replaced the new target device
> is no more a seed device. So we need to update the device
> numbers in the fs_devices as pointed by the fs_info.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
A formality: if you get a reviewed-by from somebody and the patch does
not change in the next iteration, add the tag to the patch as well. This
will ensure the review credit is not lost.
Otherwise, pinging the maintainer with a forgotten reviewed-by also works.
next prev parent reply other threads:[~2014-08-19 15:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 6:24 [PATCH 1/8] btrfs: preparatory to make btrfs_rm_dev_replace_srcdev() seed aware Anand Jain
2014-08-13 6:24 ` [PATCH 2/8] btrfs: replace seed device followed by unmount causes kernel WARNING Anand Jain
2014-08-19 15:44 ` David Sterba [this message]
2014-08-20 2:56 ` [PATCH 2/8 v2] " Anand Jain
2014-08-13 6:24 ` [PATCH 3/8] btrfs: fix rw_devices miss match after seed replace Anand Jain
2014-08-13 6:24 ` [PATCH 4/8 v2] btrfs: update sprout seed pointer when seed fs is relinquished Anand Jain
2014-08-13 6:24 ` [PATCH 5/8] btrfs: fix memory leak when there is no more seed device Anand Jain
2014-08-13 6:24 ` [PATCH 6/8] btrfs: rw_devices shouldn't be incremented for seed fs in btrfs_rm_dev_replace_srcdev() Anand Jain
2014-08-13 6:24 ` [PATCH 7/8] btrfs: fix typo in the log message Anand Jain
2014-08-13 6:24 ` [PATCH 8/8] btrfs: rename total_bytes to avoid confusion Anand Jain
2014-08-19 15:37 ` David Sterba
2014-08-20 2:54 ` [PATCH 8/8 v2] " Anand Jain
2014-08-20 14:29 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819154428.GA1553@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).