From: Johannes Hirte <johannes.hirte@datenkhaos.de>
To: Anand Jain <Anand.Jain@oracle.com>
Cc: "xavier.gnata@gmail.com" <xavier.gnata@gmail.com>,
linux-btrfs@vger.kernel.org
Subject: Re: "Btrfs: device_list_add() should not update list when mounted" breaks subvol mount
Date: Tue, 16 Sep 2014 00:17:57 +0200 [thread overview]
Message-ID: <20140916001757.62ea5219@datenkhaos.de> (raw)
In-Reply-To: <54172465.80002@oracle.com>
On Tue, 16 Sep 2014 01:39:49 +0800
Anand Jain <Anand.Jain@oracle.com> wrote:
>
>
> On 16/09/2014 01:14, Johannes Hirte wrote:
> > On Mon, 15 Sep 2014 20:32:58 +0800
> > Anand Jain <Anand.Jain@oracle.com> wrote:
> >
> >>
> >>
> >> Hi Johannes,
> >>
> >> Can I have you this tested.. ? Thanks.
> >>
> >>
> >> -------
> >> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> >> index e9676a4..1224b61 100644
> >> --- a/fs/btrfs/volumes.c
> >> +++ b/fs/btrfs/volumes.c
> >> @@ -533,7 +533,7 @@ static noinline int device_list_add(const char
> >> *path,
> >> * the btrfs dev scan cli, after FS has been
> >> mounted. */
> >> if (fs_devices->opened) {
> >> - return -EBUSY;
> >> + goto out;
> >> } else {
> >> /*
> >> * That is if the FS is _not_ mounted
> >> and if you @@ -566,6 +566,7 @@ static noinline int
> >> device_list_add(const char *path, if (!fs_devices->opened)
> >> device->generation = found_transid;
> >>
> >> +out:
> >> *fs_devices_ret = fs_devices;
> >>
> >> return ret;
> >> -------
> >
> > With this change, it works again without initramfs.
>
> Thanks. I am bit confused, is there any configuration that is
> still not working, even with the above changes.
>
> Anand
At moment, I'm not aware of any. But I will test the remaining systems
I have.
regards,
Johannes
next prev parent reply other threads:[~2014-09-15 22:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 22:22 "Btrfs: device_list_add() should not update list when mounted" breaks subvol mount Johannes Hirte
2014-09-10 23:26 ` Anand Jain
2014-09-11 2:37 ` Anand Jain
2014-09-12 20:43 ` xavier.gnata
2014-09-13 5:36 ` Anand Jain
2014-09-13 17:55 ` Johannes Hirte
2014-09-13 21:23 ` Johannes Hirte
2014-09-14 0:45 ` Duncan
2014-09-15 17:13 ` Johannes Hirte
2014-09-15 12:32 ` Anand Jain
2014-09-15 17:14 ` Johannes Hirte
2014-09-15 17:39 ` Anand Jain
2014-09-15 22:17 ` Johannes Hirte [this message]
2014-09-16 21:55 ` Anand Jain
2014-09-17 8:49 ` Anand Jain
2014-09-14 11:12 ` xavier.gnata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916001757.62ea5219@datenkhaos.de \
--to=johannes.hirte@datenkhaos.de \
--cc=Anand.Jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xavier.gnata@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).