From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Omar Sandoval <osandov@osandov.com>, Chris Mason <clm@fb.com>,
Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Return a value from printk_ratelimited
Date: Sun, 21 Sep 2014 06:25:12 -0700 [thread overview]
Message-ID: <20140921132512.GI4723@linux.vnet.ibm.com> (raw)
In-Reply-To: <1411150553.24444.29.camel@joe-AO725>
On Fri, Sep 19, 2014 at 11:15:53AM -0700, Joe Perches wrote:
> On Fri, 2014-09-19 at 13:21 -0400, Steven Rostedt wrote:
> > On Fri, 19 Sep 2014 02:01:29 -0700
> > Omar Sandoval <osandov@osandov.com> wrote:
> >
> > > printk returns an integer; there's no reason for printk_ratelimited to swallow
> > > it.
>
> Except for the lack of usefulness of the return value itself.
> See: https://lkml.org/lkml/2009/10/7/275
When printk()'s return value is changed to void, then yes, we should
clearly change this code to match that.
So, I have to ask... What happened to the patch later in that series
that was to remove the uses of the printk() return value?
Thanx, Paul
next prev parent reply other threads:[~2014-09-21 13:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 9:01 [PATCH v2 0/2] Move BTRFS RCU string to common library Omar Sandoval
2014-09-19 9:01 ` [PATCH v2 1/2] Return a value from printk_ratelimited Omar Sandoval
2014-09-19 17:21 ` Steven Rostedt
2014-09-19 18:15 ` Joe Perches
2014-09-21 13:25 ` Paul E. McKenney [this message]
2014-09-21 15:53 ` Joe Perches
2014-09-19 9:01 ` [PATCH v2 2/2] Move BTRFS RCU string to common library Omar Sandoval
2014-09-26 23:25 ` josh
2014-09-19 15:45 ` [PATCH v2 0/2] " Paul E. McKenney
2014-09-19 15:47 ` Chris Mason
2014-09-19 16:05 ` Paul E. McKenney
2014-09-19 16:22 ` Chris Mason
2014-09-21 13:25 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140921132512.GI4723@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=clm@fb.com \
--cc=jbacik@fb.com \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=osandov@osandov.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).