linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 00/15] xfstests: new btrfs stress test cases
Date: Thu, 25 Sep 2014 15:39:07 +1000	[thread overview]
Message-ID: <20140925053907.GC4758@dastard> (raw)
In-Reply-To: <1411019379-8104-1-git-send-email-eguan@redhat.com>

Btrfs developers,

Can someone who knows how this is all supposed to work pass an eye
over this patch series to determine the validity of what is being
tested?  Given the number of problems this patchset seems to expose,
it looks pretty important to me to get this into all of your regular
testing. I can't make judgement on whether the tests are valid
things to do to btrfs, so I'm reliant on people with actual btrfs
expertise to vet these patches...

-Dave.

On Thu, Sep 18, 2014 at 01:49:24PM +0800, Eryu Guan wrote:
> This patchset add new stress test cases for btrfs by running two
> different btrfs operations simultaneously under fsstress to ensure
> btrfs doesn't hang or oops in such situations. btrfs scrub and
> btrfs check will be run after each test.
> 
> The test matrix is the combination of 6 btrfs operations:
> 
> 	balance
> 	create/mount/umount/delete subvolume
> 	replace device
> 	scrub
> 	defrag
> 	remount with different compress algorithms
> 	
> Short descriptions:
> 
> 	059: balance-subvolume
> 	060: balance-scrub
> 	061: balance-defrag
> 	062: balance-remount
> 	063: balance-replace
> 	064: subvolume-replace
> 	065: subvolume-scrub
> 	066: subvolume-defrag
> 	067: subvolume-remount
> 	068: replace-scrub
> 	069: replace-defrag
> 	070: replace-remount
> 	071: scrub-defrag
> 	072: scrub-remount
> 	073: defrag-remount
> 
> Some issues I've seen:
> 
> 1. subvolume cannot be mounted with selinux context, so you may see
>    such logs in dmesg
> 
>    SELinux: mount invalid.  Same superblock, different security settings for (dev dm-8, type btrfs)
> 
>    I've reported the bug to btrfs list, see
>    [BUG] cannot mount subvolume with selinux context
>    http://www.spinics.net/lists/linux-btrfs/msg36779.html
> 
> 2. btrfs replace operation always returns ENOENT if balance is running
>    So in 063.full you'll see
> 
>    ERROR: ioctl(DEV_REPLACE_START) failed on "/mnt/testarea/scratch": No such file or directory, no error
> 
>    Not sure if it's btrfs bug, at least I think the error code is misleading
> 
> 3. replace operation hangs the kernel(3.16-rc4+ and 3.17-rc2+) with fsstress running
>    So case 064/068/069/070 will hang
> 
> 
> Changes since v2:
> - mount subvolume at $TEST_DIR/$seq.mnt not $tmp.mnt
> - don't rm -rf $tmp.* which is dangerous
> - remove unnecessary btrfs filesystem sync operation
> - update _scratch_pool_mkfs to deal with dup profile
> - add more comments for each stress operation
> - rename _btrfs_stress_remount to _btrfs_stress_remount_compress (hope it's better...)
> - add _btrfs_get_profile_configs to remove duplicated test case array in each case
> - use _require_scratch_nocheck and _check_scratch_fs after each loop
> 
> Changes since v1:
> - put common operations in common/rc as functions and share them across these tests
> - append mkfs options to _scratch_mkfs and _scratch_pool_mkfs instead of updating $MKFS_OPTIONS
> - rebase on top of master and re-number starting from btrfs/059
> 
> Thanks,
> Eryu Guan
> 
> Eryu Guan (15):
>   btrfs: new test to run btrfs balance and subvolume test simultaneously
>   btrfs: new test to run btrfs balance and scrub simultaneously
>   btrfs: new test to run btrfs balance and defrag operations simultaneously
>   btrfs: new case to run btrfs balance and remount with different compress algorithms
>   btrfs: new case to run btrfs balance and device replace operations simultaneously
>   btrfs: new case to run btrfs subvolume create/delete operations and device replace simultaneously
>   btrfs: new case to run btrfs subvolume create/delete operations and scrub simultaneously
>   btrfs: new case to run btrfs subvolume create/delete and defrag operations simultaneously
>   btrfs: new case to run subvolume create/delete and remount with defferent compress algorithms
>   btrfs: new case to run device replace and scrub operations simultaneously
>   btrfs: new case to run device replace and defrag operations simultaneously
>   btrfs: new case to run device replace and remount with different compress algorithms simultaneously
>   btrfs: new case to run btrfs scrub and defrag operations simultaneously
>   btrfs: new case to run btrfs scrub and remount with different compress algorithms simultaneously
>   btrfs: new case to run defrag and remount with different compress algorithms simultaneously
> 
>  common/rc           | 225 +++++++++++++++++++++++++++++++++++++++++++++++++++-
>  tests/btrfs/059     | 115 +++++++++++++++++++++++++++
>  tests/btrfs/059.out |   2 +
>  tests/btrfs/060     | 114 ++++++++++++++++++++++++++
>  tests/btrfs/060.out |   2 +
>  tests/btrfs/061     | 116 +++++++++++++++++++++++++++
>  tests/btrfs/061.out |   2 +
>  tests/btrfs/062     | 114 ++++++++++++++++++++++++++
>  tests/btrfs/062.out |   2 +
>  tests/btrfs/063     | 122 ++++++++++++++++++++++++++++
>  tests/btrfs/063.out |   2 +
>  tests/btrfs/064     | 123 ++++++++++++++++++++++++++++
>  tests/btrfs/064.out |   2 +
>  tests/btrfs/065     | 115 +++++++++++++++++++++++++++
>  tests/btrfs/065.out |   2 +
>  tests/btrfs/066     | 117 +++++++++++++++++++++++++++
>  tests/btrfs/066.out |   2 +
>  tests/btrfs/067     | 116 +++++++++++++++++++++++++++
>  tests/btrfs/067.out |   2 +
>  tests/btrfs/068     | 123 ++++++++++++++++++++++++++++
>  tests/btrfs/068.out |   2 +
>  tests/btrfs/069     | 125 +++++++++++++++++++++++++++++
>  tests/btrfs/069.out |   2 +
>  tests/btrfs/070     | 123 ++++++++++++++++++++++++++++
>  tests/btrfs/070.out |   2 +
>  tests/btrfs/071     | 116 +++++++++++++++++++++++++++
>  tests/btrfs/071.out |   2 +
>  tests/btrfs/072     | 114 ++++++++++++++++++++++++++
>  tests/btrfs/072.out |   2 +
>  tests/btrfs/073     | 116 +++++++++++++++++++++++++++
>  tests/btrfs/073.out |   2 +
>  tests/btrfs/group   |  15 ++++
>  32 files changed, 2035 insertions(+), 4 deletions(-)
>  create mode 100755 tests/btrfs/059
>  create mode 100644 tests/btrfs/059.out
>  create mode 100755 tests/btrfs/060
>  create mode 100644 tests/btrfs/060.out
>  create mode 100755 tests/btrfs/061
>  create mode 100644 tests/btrfs/061.out
>  create mode 100755 tests/btrfs/062
>  create mode 100644 tests/btrfs/062.out
>  create mode 100755 tests/btrfs/063
>  create mode 100644 tests/btrfs/063.out
>  create mode 100755 tests/btrfs/064
>  create mode 100644 tests/btrfs/064.out
>  create mode 100755 tests/btrfs/065
>  create mode 100644 tests/btrfs/065.out
>  create mode 100755 tests/btrfs/066
>  create mode 100644 tests/btrfs/066.out
>  create mode 100755 tests/btrfs/067
>  create mode 100644 tests/btrfs/067.out
>  create mode 100755 tests/btrfs/068
>  create mode 100644 tests/btrfs/068.out
>  create mode 100755 tests/btrfs/069
>  create mode 100644 tests/btrfs/069.out
>  create mode 100755 tests/btrfs/070
>  create mode 100644 tests/btrfs/070.out
>  create mode 100755 tests/btrfs/071
>  create mode 100644 tests/btrfs/071.out
>  create mode 100755 tests/btrfs/072
>  create mode 100644 tests/btrfs/072.out
>  create mode 100755 tests/btrfs/073
>  create mode 100644 tests/btrfs/073.out
> 
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Dave Chinner
david@fromorbit.com

  parent reply	other threads:[~2014-09-25  5:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18  5:49 [PATCH v3 00/15] xfstests: new btrfs stress test cases Eryu Guan
2014-09-18  5:49 ` [PATCH v3 01/15] btrfs: new test to run btrfs balance and subvolume test simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 02/15] btrfs: new test to run btrfs balance and scrub simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 03/15] btrfs: new test to run btrfs balance and defrag operations simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 04/15] btrfs: new case to run btrfs balance and remount with different compress algorithms Eryu Guan
2014-09-18  5:49 ` [PATCH v3 05/15] btrfs: new case to run btrfs balance and device replace operations simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 06/15] btrfs: new case to run btrfs subvolume create/delete operations and device replace simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 07/15] btrfs: new case to run btrfs subvolume create/delete operations and scrub simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 08/15] btrfs: new case to run btrfs subvolume create/delete and defrag operations simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 09/15] btrfs: new case to run subvolume create/delete and remount with defferent compress algorithms Eryu Guan
2014-09-18  5:49 ` [PATCH v3 10/15] btrfs: new case to run device replace and scrub operations simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 11/15] btrfs: new case to run device replace and defrag " Eryu Guan
2014-09-18  5:49 ` [PATCH v3 12/15] btrfs: new case to run device replace and remount with different compress algorithms simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 13/15] btrfs: new case to run btrfs scrub and defrag operations simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 14/15] btrfs: new case to run btrfs scrub and remount with different compress algorithms simultaneously Eryu Guan
2014-09-18  5:49 ` [PATCH v3 15/15] btrfs: new case to run defrag " Eryu Guan
2014-09-25  5:39 ` Dave Chinner [this message]
2014-09-26 12:56   ` [PATCH v3 00/15] xfstests: new btrfs stress test cases Josef Bacik
2014-09-26  3:55 ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140925053907.GC4758@dastard \
    --to=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).